TrueCloudLab/coredns
16
0
Fork 2
Code Issues Pull requests 1 Projects Releases Packages Wiki Activity Actions

Add metrics for cache hits/misses (#375)

Browse source 
* Add metrics for cache hits/misses

Add counters for cache middleware hits and misses.

* Add test for cache middleware hit/miss counters.

* Fix cache hit metric incrementing.

* Add cache hit/miss metrics to dnssec middleware.

* Update README metric documentation.
This commit is contained in:
Ben Kochie 2016-10-31 19:50:50 +01:00 • committed by Miek Gieben
parent 27d893cf33
commit 775d26c5e2
6 changed files with 63 additions and 6 deletions
Download patch file Download diff file Expand all files Collapse all files

22
test/metrics_test.go
View file

@ -73,7 +73,8 @@ func TestMetricsRefused(t *testing.T) {
}
func TestMetricsCache(t *testing.T) {
metricName := "coredns_cache_size"
cacheSizeMetricName := "coredns_cache_size"
cacheHitMetricName := "coredns_cache_hits_total"
corefile := `example.net:0 {
proxy . 8.8.8.8:53
@ -97,11 +98,24 @@ func TestMetricsCache(t *testing.T) {
}
data := mtest.Scrape(t, "http://"+metrics.ListenAddr+"/metrics")
// Get the value for the metrics where the one of the labels values matches "success".
got, _ := mtest.MetricValueLabel(metricName, cache.Success, data)
// Get the value for the cache size metric where the one of the labels values matches "success".
got, _ := mtest.MetricValueLabel(cacheSizeMetricName, cache.Success, data)
if got != "1" {
t.Errorf("Expected value %s for %s, but got %s", "1", metricName, got)
t.Errorf("Expected value %s for %s, but got %s", "1", cacheSizeMetricName, got)
}
// Second request for the same response to test hit counter.
if _, err = dns.Exchange(m, udp); err != nil {
t.Fatalf("Could not send message: %s", err)
}
data = mtest.Scrape(t, "http://"+metrics.ListenAddr+"/metrics")
// Get the value for the cache hit counter where the one of the labels values matches "success".
got, _ = mtest.MetricValueLabel(cacheHitMetricName, cache.Success, data)
if got != "1" {
t.Errorf("Expected value %s for %s, but got %s", "1", cacheHitMetricName, got)
}
}