From 83e94a91b948fb6cab353fb2c59cb2e53e67763a Mon Sep 17 00:00:00 2001 From: Ayato Tokubi Date: Thu, 4 May 2023 09:47:18 +0100 Subject: [PATCH] Bump golang to 1.20.0 (#6070) Signed-off-by: Ayato Tokubi --- .github/workflows/go.coverage.yml | 2 +- .github/workflows/go.test.yml | 6 +++--- .github/workflows/golangci-lint.yml | 4 ++-- .github/workflows/make.doc.yml | 2 +- README.md | 4 ++-- go.mod | 2 +- plugin/auto/xfr.go | 2 +- 7 files changed, 11 insertions(+), 11 deletions(-) diff --git a/.github/workflows/go.coverage.yml b/.github/workflows/go.coverage.yml index ec6785c77..af1c8b418 100644 --- a/.github/workflows/go.coverage.yml +++ b/.github/workflows/go.coverage.yml @@ -11,7 +11,7 @@ jobs: - name: Install Go uses: actions/setup-go@4d34df0c2316fe8122ab82dc22947d607c0c91f9 with: - go-version: '1.19.0' + go-version: '1.20.0' id: go - name: Check out code diff --git a/.github/workflows/go.test.yml b/.github/workflows/go.test.yml index 9fec9a4b4..4ffe7c963 100644 --- a/.github/workflows/go.test.yml +++ b/.github/workflows/go.test.yml @@ -11,7 +11,7 @@ jobs: - name: Install Go uses: actions/setup-go@4d34df0c2316fe8122ab82dc22947d607c0c91f9 with: - go-version: '1.19.0' + go-version: '1.20.0' id: go - name: Check out code @@ -33,7 +33,7 @@ jobs: - name: Install Go uses: actions/setup-go@4d34df0c2316fe8122ab82dc22947d607c0c91f9 with: - go-version: '1.19.0' + go-version: '1.20.0' id: go - name: Check out code @@ -52,7 +52,7 @@ jobs: - name: Install Go uses: actions/setup-go@4d34df0c2316fe8122ab82dc22947d607c0c91f9 with: - go-version: '1.19.0' + go-version: '1.20.0' id: go - name: Check out code diff --git a/.github/workflows/golangci-lint.yml b/.github/workflows/golangci-lint.yml index afb1092d4..663ba18df 100644 --- a/.github/workflows/golangci-lint.yml +++ b/.github/workflows/golangci-lint.yml @@ -8,9 +8,9 @@ jobs: steps: - uses: actions/setup-go@4d34df0c2316fe8122ab82dc22947d607c0c91f9 with: - go-version: '1.19.0' + go-version: '1.20.0' - uses: actions/checkout@93ea575cb5d8a053eaa0ac8fa3b40d7e05a33cc8 - name: golangci-lint uses: golangci/golangci-lint-action@v3.4.0 with: - version: v1.49.0 + version: v1.52.2 diff --git a/.github/workflows/make.doc.yml b/.github/workflows/make.doc.yml index 26417140a..06f602577 100644 --- a/.github/workflows/make.doc.yml +++ b/.github/workflows/make.doc.yml @@ -18,7 +18,7 @@ jobs: - name: Setup Go uses: actions/setup-go@4d34df0c2316fe8122ab82dc22947d607c0c91f9 with: - go-version: '1.19.0' + go-version: '1.20.0' - name: Update Docs run: | diff --git a/README.md b/README.md index aedf29d4a..54b3ac837 100644 --- a/README.md +++ b/README.md @@ -53,7 +53,7 @@ out-of-tree plugins. To compile CoreDNS, we assume you have a working Go setup. See various tutorials if you don’t have that already configured. -First, make sure your golang version is 1.17 or higher as `go mod` support and other api is needed. +First, make sure your golang version is 1.20 or higher as `go mod` support and other api is needed. See [here](https://github.com/golang/go/wiki/Modules) for `go mod` details. Then, check out the project and run `make` to compile the binary: @@ -71,7 +71,7 @@ CoreDNS requires Go to compile. However, if you already have docker installed an setup a Go environment, you could build CoreDNS easily: ``` -$ docker run --rm -i -t -v $PWD:/v -w /v golang:1.18 make +$ docker run --rm -i -t -v $PWD:/v -w /v golang:1.20 make ``` The above command alone will have `coredns` binary generated. diff --git a/go.mod b/go.mod index a85a5f444..b422f94b9 100644 --- a/go.mod +++ b/go.mod @@ -1,6 +1,6 @@ module github.com/coredns/coredns -go 1.18 +go 1.20 require ( github.com/Azure/azure-sdk-for-go v68.0.0+incompatible diff --git a/plugin/auto/xfr.go b/plugin/auto/xfr.go index 828a58cfa..e6a9ba5a5 100644 --- a/plugin/auto/xfr.go +++ b/plugin/auto/xfr.go @@ -28,4 +28,4 @@ func (a Auto) Notify() error { } } return err -} \ No newline at end of file +}