TrueCloudLab/coredns
16
0
Fork 2
Code Issues Pull requests 1 Projects Releases Packages Wiki Activity Actions

Changing switch to compare on constants versus strings (#1285)

Browse source
This commit is contained in:
Brad Beam 2017-12-07 22:31:13 -06:00 • committed by John Belamaric
parent 986512892d
commit 850a024905
2 changed files with 21 additions and 20 deletions
Download patch file Download diff file Expand all files Collapse all files

21
plugin/etcd/handler.go
View file

@ -37,24 +37,25 @@ func (e *Etcd) ServeDNS(ctx context.Context, w dns.ResponseWriter, r *dns.Msg) (
records, extra []dns.RR records, extra []dns.RR
err error err error
) )
switch state.Type() {
case "A": switch state.QType() {
case dns.TypeA:
records, err = plugin.A(e, zone, state, nil, opt) records, err = plugin.A(e, zone, state, nil, opt)
case "AAAA": case dns.TypeAAAA:
records, err = plugin.AAAA(e, zone, state, nil, opt) records, err = plugin.AAAA(e, zone, state, nil, opt)
case "TXT": case dns.TypeTXT:
records, err = plugin.TXT(e, zone, state, opt) records, err = plugin.TXT(e, zone, state, opt)
case "CNAME": case dns.TypeCNAME:
records, err = plugin.CNAME(e, zone, state, opt) records, err = plugin.CNAME(e, zone, state, opt)
case "PTR": case dns.TypePTR:
records, err = plugin.PTR(e, zone, state, opt) records, err = plugin.PTR(e, zone, state, opt)
case "MX": case dns.TypeMX:
records, extra, err = plugin.MX(e, zone, state, opt) records, extra, err = plugin.MX(e, zone, state, opt)
case "SRV": case dns.TypeSRV:
records, extra, err = plugin.SRV(e, zone, state, opt) records, extra, err = plugin.SRV(e, zone, state, opt)
case "SOA": case dns.TypeSOA:
records, err = plugin.SOA(e, zone, state, opt) records, err = plugin.SOA(e, zone, state, opt)
case "NS": case dns.TypeNS:
if state.Name() == zone { if state.Name() == zone {
records, extra, err = plugin.NS(e, zone, state, opt) records, extra, err = plugin.NS(e, zone, state, opt)
break break

20
plugin/kubernetes/handler.go
View file

@ -30,24 +30,24 @@ func (k Kubernetes) ServeDNS(ctx context.Context, w dns.ResponseWriter, r *dns.M
err error err error
) )
switch state.Type() { switch state.QType() {
case "A": case dns.TypeA:
records, err = plugin.A(&k, zone, state, nil, plugin.Options{}) records, err = plugin.A(&k, zone, state, nil, plugin.Options{})
case "AAAA": case dns.TypeAAAA:
records, err = plugin.AAAA(&k, zone, state, nil, plugin.Options{}) records, err = plugin.AAAA(&k, zone, state, nil, plugin.Options{})
case "TXT": case dns.TypeTXT:
records, err = plugin.TXT(&k, zone, state, plugin.Options{}) records, err = plugin.TXT(&k, zone, state, plugin.Options{})
case "CNAME": case dns.TypeCNAME:
records, err = plugin.CNAME(&k, zone, state, plugin.Options{}) records, err = plugin.CNAME(&k, zone, state, plugin.Options{})
case "PTR": case dns.TypePTR:
records, err = plugin.PTR(&k, zone, state, plugin.Options{}) records, err = plugin.PTR(&k, zone, state, plugin.Options{})
case "MX": case dns.TypeMX:
records, extra, err = plugin.MX(&k, zone, state, plugin.Options{}) records, extra, err = plugin.MX(&k, zone, state, plugin.Options{})
case "SRV": case dns.TypeSRV:
records, extra, err = plugin.SRV(&k, zone, state, plugin.Options{}) records, extra, err = plugin.SRV(&k, zone, state, plugin.Options{})
case "SOA": case dns.TypeSOA:
records, err = plugin.SOA(&k, zone, state, plugin.Options{}) records, err = plugin.SOA(&k, zone, state, plugin.Options{})
case "NS": case dns.TypeNS:
if state.Name() == zone { if state.Name() == zone {
records, extra, err = plugin.NS(&k, zone, state, plugin.Options{}) records, extra, err = plugin.NS(&k, zone, state, plugin.Options{})
break break