more

core/setup/etcd.go

@@ -10,38 +10,53 @@ import (
 
 	"github.com/miekg/coredns/middleware"
 	"github.com/miekg/coredns/middleware/etcd"
+	"github.com/miekg/coredns/middleware/etcd/singleflight"
+	"github.com/miekg/coredns/middleware/proxy"
 
 	etcdc "github.com/coreos/etcd/client"
+	"golang.org/x/net/context"
 )
 
 const defaultEndpoint = "http://127.0.0.1:2379"
 
 // Etcd sets up the etcd middleware.
 func Etcd(c *Controller) (middleware.Middleware, error) {
-	client, err := etcdParse(c)
+	etcd, err := etcdParse(c)
 	if err != nil {
 		return nil, err
 	}
 
 	return func(next middleware.Handler) middleware.Handler {
-		return etcd.NewEtcd(client, next, c.ServerBlockHosts)
+		etcd.Next = next
+		return etcd
 	}, nil
 }
 
-func etcdParse(c *Controller) (etcdc.KeysAPI, error) {
+func etcdParse(c *Controller) (etcd.Etcd, error) {
+	etc := etcd.Etcd{
+		// make stuff configurable
+		Proxy:      proxy.New([]string{"8.8.8.8:53"}),
+		PathPrefix: "skydns",
+		Ctx:        context.Background(),
+		Inflight:   &singleflight.Group{},
+	}
 	for c.Next() {
 		if c.Val() == "etcd" {
-			// etcd [address...]
+			// etcd [origin...]
-			if !c.NextArg() {
+			client, err := newEtcdClient([]string{defaultEndpoint}, "", "", "")
-				// TODO(certs) and friends, this is client side
+			if err != nil {
-				client, err := newEtcdClient([]string{defaultEndpoint}, "", "", "")
+				return etcd.Etcd{}, err
-				return client, err
 			}
-			client, err := newEtcdClient(c.RemainingArgs(), "", "", "")
+			etc.Client = client
-			return client, err
+			etc.Zones = c.RemainingArgs()
+			if len(etc.Zones) == 0 {
+				etc.Zones = c.ServerBlockHosts
+			}
+			middleware.Zones(etc.Zones).FullyQualify()
+			return etc, nil
 		}
 	}
-	return nil, nil
+	return etcd.Etcd{}, nil
 }
 
 func newEtcdClient(endpoints []string, tlsCert, tlsKey, tlsCACert string) (etcdc.KeysAPI, error) {

middleware/etcd/etcd.go

@@ -14,28 +14,14 @@ import (
 	"golang.org/x/net/context"
 )
 
-type (
+type Etcd struct {
-	Etcd struct {
+	Next       middleware.Handler
-		Next       middleware.Handler
+	Zones      []string
-		Zones      []string
+	Proxy      proxy.Proxy
-		Proxy      proxy.Proxy
+	Client     etcdc.KeysAPI
-		client     etcdc.KeysAPI
+	Ctx        context.Context
-		ctx        context.Context
+	Inflight   *singleflight.Group
-		inflight   *singleflight.Group
+	PathPrefix string
-		PathPrefix string
-	}
-)
-
-func NewEtcd(client etcdc.KeysAPI, next middleware.Handler, zones []string) Etcd {
-	return Etcd{
-		Next:       next,
-		Zones:      zones,
-		Proxy:      proxy.New([]string{"8.8.8.8:53"}),
-		client:     client,
-		ctx:        context.Background(),
-		inflight:   &singleflight.Group{},
-		PathPrefix: "skydns", // TODO(miek): configurable
-	}
 }
 
 func (g Etcd) Records(name string, exact bool) ([]msg.Service, error) {
@@ -57,8 +43,8 @@ func (g Etcd) Records(name string, exact bool) ([]msg.Service, error) {
 
 // Get is a wrapper for client.Get that uses SingleInflight to suppress multiple outstanding queries.
 func (g Etcd) Get(path string, recursive bool) (*etcdc.Response, error) {
-	resp, err := g.inflight.Do(path, func() (interface{}, error) {
+	resp, err := g.Inflight.Do(path, func() (interface{}, error) {
-		r, e := g.client.Get(g.ctx, path, &etcdc.GetOptions{Sort: false, Recursive: recursive})
+		r, e := g.Client.Get(g.Ctx, path, &etcdc.GetOptions{Sort: false, Recursive: recursive})
 		if e != nil {
 			return nil, e
 		}

middleware/etcd/handler.go

@@ -2,6 +2,7 @@ package etcd
 
 import (
 	"github.com/miekg/coredns/middleware"
+
 	"github.com/miekg/dns"
 	"golang.org/x/net/context"
 )
@@ -35,6 +36,9 @@ func (e Etcd) ServeDNS(ctx context.Context, w dns.ResponseWriter, r *dns.Msg) (i
 	case "SRV":
 		records, extra, err = e.SRV(zone, state)
 	default:
+		// For SOA and NS we might still want this
+		// and use dns.<zones> as the name to put these
+		// also for stub
 		// rwrite and return
 		// Nodata response
 		// also catch other types, so that they return NODATA

middleware/zone.go

@@ -1,6 +1,10 @@
 package middleware
 
-import "strings"
+import (
+	"strings"
+
+	"github.com/miekg/dns"
+)
 
 type Zones []string
 
@@ -11,6 +15,7 @@ func (z Zones) Matches(qname string) string {
 	zone := ""
 	// TODO(miek): use IsSubDomain here?
 	for _, zname := range z {
+		println(zname, qname)
 		if strings.HasSuffix(qname, zname) {
 			if len(zname) > len(zone) {
 				zone = zname
@@ -19,3 +24,11 @@ func (z Zones) Matches(qname string) string {
 	}
 	return zone
 }
+
+// Fully qualify all zones in z
+func (z Zones) FullyQualify() {
+	for i, _ := range z {
+		z[i] = dns.Fqdn(z[i])
+	}
+
+}