TrueCloudLab/coredns
16
0
Fork 2
Code Issues Pull requests 1 Projects Releases Packages Wiki Activity Actions

plugin/kubernetes: Fix dns programming duration metric (#4255)

Browse source 
* get data reqd to record latency before calling toFuncs
* refactor out unnecessary toFunc wrappers
* remove latency metric unit tests per PR feedback

Signed-off-by: Chris O'Haver <cohaver@infoblox.com>
This commit is contained in:
Chris O'Haver 2020-12-01 15:29:05 -05:00 • committed by GitHub
parent 56eea6e609
commit 9121e78496
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
9 changed files with 166 additions and 196 deletions
Download patch file Download diff file Expand all files Collapse all files

10
plugin/kubernetes/informer_test.go
View file

@ -11,7 +11,7 @@ import (
)
func TestDefaultProcessor(t *testing.T) {
pbuild := object.DefaultProcessor(object.ToService(true), nil)
pbuild := object.DefaultProcessor(object.ToService, nil)
reh := cache.ResourceEventHandlerFuncs{}
idx := cache.NewIndexer(cache.DeletionHandlingMetaNamespaceKeyFunc, cache.Indexers{})
processor := pbuild(idx, reh)
@ -30,8 +30,8 @@ func testProcessor(t *testing.T, processor cache.ProcessFunc, idx cache.Indexer)
// Add the objects
err := processor(cache.Deltas{
{Type: cache.Added, Object: obj},
{Type: cache.Added, Object: obj2},
{Type: cache.Added, Object: obj.DeepCopy()},
{Type: cache.Added, Object: obj2.DeepCopy()},
})
if err != nil {
t.Fatalf("add failed: %v", err)
@ -55,7 +55,7 @@ func testProcessor(t *testing.T, processor cache.ProcessFunc, idx cache.Indexer)
obj.Spec.ClusterIP = "1.2.3.5"
err = processor(cache.Deltas{{
Type: cache.Updated,
Object: obj,
Object: obj.DeepCopy(),
}})
if err != nil {
t.Fatalf("update failed: %v", err)
@ -78,7 +78,7 @@ func testProcessor(t *testing.T, processor cache.ProcessFunc, idx cache.Indexer)
// Delete an object
err = processor(cache.Deltas{{
Type: cache.Deleted,
Object: obj2,
Object: obj2.DeepCopy(),
}})
if err != nil {
t.Fatalf("delete test failed: %v", err)