TrueCloudLab/coredns
16
0
Fork 2
Code Issues Pull requests 4 Projects Releases Packages Wiki Activity Actions

return standardized text for ready and health endpoint (#3195)

Browse source
This commit is contained in:
xieyanker 2019-08-26 18:31:24 +08:00 • committed by Miek Gieben
parent dd8238ba9b
commit 9fe7fb95c6
4 changed files with 4 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
plugin/health/health.go
View file

@ -42,7 +42,7 @@ func (h *health) OnStartup() error {
h.mux.HandleFunc("/health", func(w http.ResponseWriter, r *http.Request) { h.mux.HandleFunc("/health", func(w http.ResponseWriter, r *http.Request) {
// We're always healthy. // We're always healthy.
w.WriteHeader(http.StatusOK) w.WriteHeader(http.StatusOK)
io.WriteString(w, "OK") io.WriteString(w, http.StatusText(http.StatusOK))
return return
}) })

2
plugin/health/health_test.go
View file

@ -31,7 +31,7 @@ func TestHealth(t *testing.T) {
} }
response.Body.Close() response.Body.Close()
if string(content) != "OK" { if string(content) != http.StatusText(http.StatusOK) {
t.Errorf("Invalid response body: expecting 'OK', got '%s'", string(content)) t.Errorf("Invalid response body: expecting 'OK', got '%s'", string(content))
} }
} }

2
plugin/ready/ready.go
View file

@ -45,7 +45,7 @@ func (rd *ready) onStartup() error {
ok, todo := plugins.Ready() ok, todo := plugins.Ready()
if ok { if ok {
w.WriteHeader(http.StatusOK) w.WriteHeader(http.StatusOK)
io.WriteString(w, "OK") io.WriteString(w, http.StatusText(http.StatusOK))
return return
} }
log.Infof("Still waiting on: %q", todo) log.Infof("Still waiting on: %q", todo)

2
test/reload_test.go
View file

@ -110,7 +110,7 @@ func TestReloadMetricsHealth(t *testing.T) {
} }
ok, _ := ioutil.ReadAll(resp.Body) ok, _ := ioutil.ReadAll(resp.Body)
resp.Body.Close() resp.Body.Close()
if string(ok) != "OK" { if string(ok) != http.StatusText(http.StatusOK) {
t.Errorf("Failed to receive OK, got %s", ok) t.Errorf("Failed to receive OK, got %s", ok)
} }