From a40345d65fa5925d10ce38ea61a7256e6ba7a89b Mon Sep 17 00:00:00 2001 From: Yong Tang Date: Sat, 19 May 2018 15:03:32 -0700 Subject: [PATCH] Fix `make check` dependency error (#1818) While invoking `make check` from a fresh new environment the following failure occured: ``` [ec2-user@..... coredns]$ docker run -i -t --rm -v $PWD:/go/src/github.com/coredns/coredns -w /go/src/github.com/coredns/coredns golang:1.10 root@e2d6a6c17132:/go/src/github.com/coredns/coredns# make check ** presubmit/context ** presubmit/test-lowercase ( gometalinter --deadline=2m --disable-all --enable=goimports --vendor --exclude=^pb/ ./... || true ) /bin/sh: 1: gometalinter: not found go generate coredns.go ``` This fix fixes the issue in Makefile so that deps could be installed first. Signed-off-by: Yong Tang --- Makefile | 2 ++ 1 file changed, 2 insertions(+) diff --git a/Makefile b/Makefile index 1ed989b51..dd7123e09 100644 --- a/Makefile +++ b/Makefile @@ -85,6 +85,8 @@ linter: .PHONY: goimports goimports: + go get -u github.com/alecthomas/gometalinter + gometalinter --install goimports ( gometalinter --deadline=2m --disable-all --enable=goimports --vendor --exclude=^pb/ ./... || true ) # Presubmit runs all scripts in .presubmit; any non 0 exit code will fail the build.