TrueCloudLab/coredns
16
0
Fork 2
Code Issues Pull requests 3 Projects Releases Packages Wiki Activity Actions

be sure to close connection after completion of xfr out. (#2866)

Browse source 
otherwise the connection and associated socket stay in the CLOSE_WAIT
state unless/until golang runtime performs GC.
This commit is contained in:
JINMEI Tatuya 2019-06-04 23:21:59 -07:00 • committed by Miek Gieben
parent d3e2ef73b8
commit a657e1f661
1 changed files with 4 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
plugin/file/xfr.go
View file

@ -33,7 +33,10 @@ func (x Xfr) ServeDNS(ctx context.Context, w dns.ResponseWriter, r *dns.Msg) (in
ch := make(chan *dns.Envelope) ch := make(chan *dns.Envelope)
defer close(ch) defer close(ch)
tr := new(dns.Transfer) tr := new(dns.Transfer)
go tr.Out(w, r, ch) go func() {
tr.Out(w, r, ch)
w.Close()
}()
j, l := 0, 0 j, l := 0, 0
records = append(records, records[0]) // add closing SOA to the end records = append(records, records[0]) // add closing SOA to the end
@ -51,7 +54,6 @@ func (x Xfr) ServeDNS(ctx context.Context, w dns.ResponseWriter, r *dns.Msg) (in
} }
w.Hijack() w.Hijack()
// w.Close() // Client closes connection
return dns.RcodeSuccess, nil return dns.RcodeSuccess, nil
} }