TrueCloudLab/coredns
16
0
Fork 2
Code Issues Pull requests 4 Projects Releases Packages Wiki Activity Actions

plugin/route53: fix multiple route 53 zones issue (#2117)

Browse source
This commit is contained in:
Can Yucel 2018-09-22 05:26:17 -07:00 • committed by Miek Gieben
parent 1697ab359d
commit b3d69f1c7f
2 changed files with 3 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
plugin/route53/route53.go
View file

@ -140,7 +140,7 @@ func (h *Route53) updateZones(ctx context.Context) error {
errc := make(chan error) errc := make(chan error)
defer close(errc) defer close(errc)
for zName, z := range h.zones { for zName, z := range h.zones {
go func(zName string) { go func(zName string, z *zone) {
var err error var err error
defer func() { defer func() {
errc <- err errc <- err
@ -170,7 +170,7 @@ func (h *Route53) updateZones(ctx context.Context) error {
h.zMu.Lock() h.zMu.Lock()
z.z = newZ z.z = newZ
h.zMu.Unlock() h.zMu.Unlock()
}(zName) }(zName, z)
} }
// Collect errors (if any). This will also sync on all zones updates // Collect errors (if any). This will also sync on all zones updates
// completion. // completion.

2
plugin/route53/route53_test.go
View file

@ -71,7 +71,7 @@ func TestRoute53(t *testing.T) {
t.Fatalf("Expected errors for zone bad.") t.Fatalf("Expected errors for zone bad.")
} }
r, err = New(ctx, fakeRoute53{}, map[string]string{"org.": "1234567890"}, &upstream.Upstream{}) r, err = New(ctx, fakeRoute53{}, map[string]string{"org.": "1234567890", "gov.": "Z098765432"}, &upstream.Upstream{})
if err != nil { if err != nil {
t.Fatalf("Failed to create Route53: %v", err) t.Fatalf("Failed to create Route53: %v", err)
} }