TrueCloudLab/coredns
16
0
Fork 2
Code Issues Pull requests 4 Projects Releases Packages Wiki Activity Actions

Use the correct root domain name in the proxy plugin's TestHealthX tests (#6395)

Browse source 
When packing the empty domain name, miekg/dns can end up creating
corrupt DNS messages. With some planned unpacking changes, this now
trips an error condition and causes these tests to fail. Correct this
by using the root domain explicitly as this gets correctly encoded on
the wire.

Signed-off-by: Tom Thorogood <me+github@tomthorogood.net>
This commit is contained in:
Tom Thorogood 2023-11-09 06:30:32 +10:30 • committed by GitHub
parent 4d28751613
commit b541b4ea49
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
1 changed files with 4 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

8
plugin/pkg/proxy/health_test.go
View file

@ -23,7 +23,7 @@ func TestHealth(t *testing.T) {
}) })
defer s.Close() defer s.Close()
hc := NewHealthChecker("TestHealth", transport.DNS, true, "") hc := NewHealthChecker("TestHealth", transport.DNS, true, ".")
hc.SetReadTimeout(10 * time.Millisecond) hc.SetReadTimeout(10 * time.Millisecond)
hc.SetWriteTimeout(10 * time.Millisecond) hc.SetWriteTimeout(10 * time.Millisecond)
@ -53,7 +53,7 @@ func TestHealthTCP(t *testing.T) {
}) })
defer s.Close() defer s.Close()
hc := NewHealthChecker("TestHealthTCP", transport.DNS, true, "") hc := NewHealthChecker("TestHealthTCP", transport.DNS, true, ".")
hc.SetTCPTransport() hc.SetTCPTransport()
hc.SetReadTimeout(10 * time.Millisecond) hc.SetReadTimeout(10 * time.Millisecond)
hc.SetWriteTimeout(10 * time.Millisecond) hc.SetWriteTimeout(10 * time.Millisecond)
@ -84,7 +84,7 @@ func TestHealthNoRecursion(t *testing.T) {
}) })
defer s.Close() defer s.Close()
hc := NewHealthChecker("TestHealthNoRecursion", transport.DNS, false, "") hc := NewHealthChecker("TestHealthNoRecursion", transport.DNS, false, ".")
hc.SetReadTimeout(10 * time.Millisecond) hc.SetReadTimeout(10 * time.Millisecond)
hc.SetWriteTimeout(10 * time.Millisecond) hc.SetWriteTimeout(10 * time.Millisecond)
@ -108,7 +108,7 @@ func TestHealthTimeout(t *testing.T) {
}) })
defer s.Close() defer s.Close()
hc := NewHealthChecker("TestHealthTimeout", transport.DNS, false, "") hc := NewHealthChecker("TestHealthTimeout", transport.DNS, false, ".")
hc.SetReadTimeout(10 * time.Millisecond) hc.SetReadTimeout(10 * time.Millisecond)
hc.SetWriteTimeout(10 * time.Millisecond) hc.SetWriteTimeout(10 * time.Millisecond)