From be8c288839e3fb17c1dc5ab6f63659b4268c12f7 Mon Sep 17 00:00:00 2001 From: Miek Gieben Date: Sat, 19 Aug 2017 12:20:17 +0100 Subject: [PATCH] up coverage --- middleware/kubernetes/parse_test.go | 28 +++++++++------------------- 1 file changed, 9 insertions(+), 19 deletions(-) diff --git a/middleware/kubernetes/parse_test.go b/middleware/kubernetes/parse_test.go index b08d31147..e44fb09f4 100644 --- a/middleware/kubernetes/parse_test.go +++ b/middleware/kubernetes/parse_test.go @@ -13,28 +13,18 @@ func TestParseRequest(t *testing.T) { tests := []struct { query string - qtype uint16 expected string // output from r.String() }{ - { - // valid SRV request - "_http._tcp.webs.mynamespace.svc.inter.webs.test.", dns.TypeSRV, - "http.tcp..webs.mynamespace.svc", - }, - { - // wildcard acceptance - "*.any.*.any.svc.inter.webs.test.", dns.TypeSRV, - "*.any..*.any.svc", - }, - { - // A request of endpoint - "1-2-3-4.webs.mynamespace.svc.inter.webs.test.", dns.TypeA, - "*.*.1-2-3-4.webs.mynamespace.svc", - }, + // valid SRV request + {"_http._tcp.webs.mynamespace.svc.inter.webs.test.", "http.tcp..webs.mynamespace.svc"}, + // wildcard acceptance + {"*.any.*.any.svc.inter.webs.test.", "*.any..*.any.svc"}, + // A request of endpoint + {"1-2-3-4.webs.mynamespace.svc.inter.webs.test.", "*.*.1-2-3-4.webs.mynamespace.svc"}, } for i, tc := range tests { m := new(dns.Msg) - m.SetQuestion(tc.query, tc.qtype) + m.SetQuestion(tc.query, dns.TypeA) state := request.Request{Zone: zone, Req: m} r, e := k.parseRequest(state) @@ -52,8 +42,8 @@ func TestParseInvalidRequest(t *testing.T) { k := New([]string{zone}) invalid := []string{ - "webs.mynamespace.pood.inter.webs.test.", // Request must be for pod or svc subdomain. - "too.long.for.what.I.am.trying.to.do.inter.webs.tests.", // Too long. + "webs.mynamespace.pood.inter.webs.test.", // Request must be for pod or svc subdomain. + "too.long.for.what.I.am.trying.to.pod.inter.webs.tests.", // Too long. } for i, query := range invalid {