Golint (#548)

* linter fixes

* Golint and format code

* fmt

core/dnsserver/zdirectives.go

@@ -1,4 +1,5 @@
 // generated by directives_generate.go; DO NOT EDIT
+
 package dnsserver
 
 // Directives are registered in the order they should be

core/zmiddleware.go

@@ -1,7 +1,9 @@
 // generated by directives_generate.go; DO NOT EDIT
+
 package core
 
 import (
+	// Include all middleware.
 	_ "github.com/coredns/coredns/middleware/auto"
 	_ "github.com/coredns/coredns/middleware/bind"
 	_ "github.com/coredns/coredns/middleware/cache"

directives_generate.go

@@ -59,6 +59,7 @@ func genImports(file, pack string, mi map[string]string) {
 		outs += "\n"
 	}
 
+	outs += "// Include all middleware.\n"
 	for _, v := range mi {
 		outs += `_ "` + v + `"` + "\n"
 	}
@@ -114,5 +115,5 @@ func fatalIfErr(err error) {
 const (
 	middlewarePath = "github.com/coredns/coredns/middleware/"
 	middlewareFile = "middleware.cfg"
-	header         = "// generated by directives_generate.go; DO NOT EDIT\n"
+	header         = "// generated by directives_generate.go; DO NOT EDIT\n\n"
 )

middleware/kubernetes/handler.go

@@ -32,7 +32,7 @@ func (k Kubernetes) ServeDNS(ctx context.Context, w dns.ResponseWriter, r *dns.M
 		// If this is a PTR request, and the request is in a defined
 		// pod/service cidr range, process the request in this middleware,
 		// otherwise pass to next middleware.
-		if !k.IsRequestInReverseRange(state) {
+		if !k.isRequestInReverseRange(state) {
 			return middleware.NextOrFailure(k.Name(), k.Next, ctx, w, r)
 		}
 		// Set the zone to this specific request.

middleware/kubernetes/kubernetes.go

@@ -130,7 +130,7 @@ func (k *Kubernetes) Reverse(state request.Request, exact bool, opt middleware.O
 	return records, nil, nil
 }
 
-func (k *Kubernetes) IsRequestInReverseRange(state request.Request) bool {
+func (k *Kubernetes) isRequestInReverseRange(state request.Request) bool {
 	ip := dnsutil.ExtractAddressFromReverse(state.Name())
 	for _, c := range k.ReverseCidrs {
 		if c.Contains(net.ParseIP(ip)) {

middleware/kubernetes/setup.go

@@ -67,7 +67,7 @@ func kubernetesParse(c *caddy.Controller) (*Kubernetes, error) {
 			middleware.Zones(k8s.Zones).Normalize()
 
 			if k8s.Zones == nil || len(k8s.Zones) < 1 {
-				return nil, errors.New("Zone name must be provided for kubernetes middleware.")
+				return nil, errors.New("zone name must be provided for kubernetes middleware")
 			}
 
 			k8s.primaryZone = -1
@@ -80,7 +80,7 @@ func kubernetesParse(c *caddy.Controller) (*Kubernetes, error) {
 			}
 
 			if k8s.primaryZone == -1 {
-				return nil, errors.New("A non-reverse zone name must be given for Kubernetes.")
+				return nil, errors.New("non-reverse zone name must be given for Kubernetes")
 			}
 
 			for c.NextBlock() {

middleware/proxy/dns.go

@@ -20,7 +20,7 @@ func newDNSEx() *dnsEx {
 	return &dnsEx{group: new(singleflight.Group), Timeout: defaultTimeout * time.Second}
 }
 
-func (g *dnsEx) Protocol() string          { return "dns" }
+func (d *dnsEx) Protocol() string          { return "dns" }
 func (d *dnsEx) OnShutdown(p *Proxy) error { return nil }
 func (d *dnsEx) OnStartup(p *Proxy) error  { return nil }
 

middleware/rewrite/class.go

@@ -12,7 +12,7 @@ type ClassRule struct {
 	fromClass, toClass uint16
 }
 
-// Initializer
+// New initializes rule.
 func (rule ClassRule) New(args ...string) Rule {
 	from, to := args[0], strings.Join(args[1:], " ")
 	return &ClassRule{dns.StringToClass[from], dns.StringToClass[to]}

middleware/rewrite/field.go

@@ -1,11 +1,9 @@
 // Package rewrite is middleware for rewriting requests internally to something different.
 package rewrite
 
-/*
+// Fields defines additional FIELD keywords may be implemented to support more rewrite use-cases.
-Additional FIELD keywords may be implemented to support more rewrite use-cases.
+// New Rule types must be added to the Fields map.
-New Rule types must be added to the Fields map.
+// The type must implement `New` and `Rewrite` functions.
-The type must implement `New` and `Rewrite` functions.
-*/
 var Fields = map[string]Rule{
 	"name":  NameRule{},
 	"type":  TypeRule{},

middleware/rewrite/name.go

@@ -13,7 +13,7 @@ type NameRule struct {
 	From, To string
 }
 
-// Initializer
+// New initializes a new rule.
 func (rule NameRule) New(args ...string) Rule {
 	from, to := args[0], strings.Join(args[1:], " ")
 	return &NameRule{middleware.Name(from).Normalize(), middleware.Name(to).Normalize()}

middleware/rewrite/type.go

@@ -12,7 +12,7 @@ type TypeRule struct {
 	fromType, toType uint16
 }
 
-// Initializer
+// New initializes a rule.
 func (rule TypeRule) New(args ...string) Rule {
 	from, to := args[0], strings.Join(args[1:], " ")
 	return &TypeRule{dns.StringToType[from], dns.StringToType[to]}

middleware/trace/setup.go

@@ -59,22 +59,22 @@ func traceParse(c *caddy.Controller) (*Trace, error) {
 		if err != nil {
 			return tr, err
 		}
-                for c.NextBlock() {
+		for c.NextBlock() {
-                        switch c.Val() {
+			switch c.Val() {
-                        case "every":
+			case "every":
-                                args := c.RemainingArgs()
+				args := c.RemainingArgs()
-                                if len(args) != 1 {
+				if len(args) != 1 {
-                                        return nil, c.ArgErr()
+					return nil, c.ArgErr()
-                                }
+				}
-                                tr.every, err = strconv.ParseUint(args[0], 10, 64)
+				tr.every, err = strconv.ParseUint(args[0], 10, 64)
-                                if err != nil {
+				if err != nil {
-                                        return nil, err
+					return nil, err
-                                }
+				}
 			case "service":
 				args := c.RemainingArgs()
-                                if len(args) != 1 {
+				if len(args) != 1 {
-                                        return nil, c.ArgErr()
+					return nil, c.ArgErr()
-                                }
+				}
 				tr.serviceName = args[0]
 			case "client_server":
 				args := c.RemainingArgs()
@@ -102,12 +102,12 @@ func normalizeEndpoint(epType, ep string) (string, error) {
 		}
 		return ep, nil
 	default:
-		return "", fmt.Errorf("Tracing endpoint type '%s' is not supported.", epType)
+		return "", fmt.Errorf("tracing endpoint type '%s' is not supported", epType)
 	}
 }
 
 const (
-	defEP     = "localhost:9411"
+	defEP          = "localhost:9411"
-	defEpType = "zipkin"
+	defEpType      = "zipkin"
 	defServiceName = "coredns"
 )

middleware/trace/setup_test.go

@@ -8,12 +8,12 @@ import (
 
 func TestTraceParse(t *testing.T) {
 	tests := []struct {
-		input     string
+		input        string
-		shouldErr bool
+		shouldErr    bool
-		endpoint  string
+		endpoint     string
-		every	uint64
+		every        uint64
-		serviceName	string
+		serviceName  string
-		clientServer	bool
+		clientServer bool
 	}{
 		// oks
 		{`trace`, false, "http://localhost:9411/api/v1/spans", 1, `coredns`, false},

middleware/trace/trace.go

@@ -21,10 +21,10 @@ type Trace struct {
 	Endpoint        string
 	EndpointType    string
 	Tracer          ot.Tracer
-	serviceName	string
+	serviceName     string
-	clientServer	bool
+	clientServer    bool
-	every		uint64
+	every           uint64
-	count		uint64
+	count           uint64
 	Once            sync.Once
 }