TrueCloudLab/coredns
16
0
Fork 2
Code Issues Pull requests 1 Projects Releases Packages Wiki Activity Actions

Fix golint warnings (#4241)

Browse source 
Include:
1. plugin/forward/type.go:8:2: const typeUdp should be typeUDP
2. plugin/forward/type.go:9:2: const typeTcp should be typeTCP
3. plugin/forward/type.go:10:2: const typeTls should be typeTLS
4. plugin/kubernetes/metrics.go:24:2: var DnsProgrammingLatency should be DNSProgrammingLatency
5. plugin/kubernetes/metrics_test.go:124:102: func parameter clusterIp should be clusterIP

Signed-off-by: zouyu <zouy.fnst@cn.fujitsu.com>
This commit is contained in:
ZouYu 2020-10-28 14:39:56 +08:00 • committed by GitHub
parent d6660f369e
commit c58e4b09fc
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
4 changed files with 21 additions and 21 deletions
Download patch file Download diff file Expand all files Collapse all files

10
plugin/kubernetes/metrics_test.go
View file

@ -20,7 +20,7 @@ const (
namespace = "testns"
)
func TestDnsProgrammingLatency(t *testing.T) {
func TestDNSProgrammingLatency(t *testing.T) {
client := fake.NewSimpleClientset()
now := time.Now()
ctx := context.TODO()
@ -32,7 +32,7 @@ func TestDnsProgrammingLatency(t *testing.T) {
durationSinceFunc = func(t time.Time) time.Duration {
return now.Sub(t)
}
DnsProgrammingLatency.Reset()
DNSProgrammingLatency.Reset()
go controller.Run()
subset1 := []api.EndpointSubset{{
@ -86,7 +86,7 @@ func TestDnsProgrammingLatency(t *testing.T) {
coredns_kubernetes_dns_programming_duration_seconds_sum{service_kind="headless_with_selector"} 3
coredns_kubernetes_dns_programming_duration_seconds_count{service_kind="headless_with_selector"} 2
`
if err := testutil.CollectAndCompare(DnsProgrammingLatency, strings.NewReader(expected)); err != nil {
if err := testutil.CollectAndCompare(DNSProgrammingLatency, strings.NewReader(expected)); err != nil {
t.Error(err)
}
}
@ -121,11 +121,11 @@ func updateEndpoints(t *testing.T, client kubernetes.Interface, name string, tri
}
}
func createService(t *testing.T, client kubernetes.Interface, controller dnsController, name string, clusterIp string) {
func createService(t *testing.T, client kubernetes.Interface, controller dnsController, name string, clusterIP string) {
ctx := context.TODO()
if _, err := client.CoreV1().Services(namespace).Create(ctx, &api.Service{
ObjectMeta: meta.ObjectMeta{Namespace: namespace, Name: name},
Spec: api.ServiceSpec{ClusterIP: clusterIp},
Spec: api.ServiceSpec{ClusterIP: clusterIP},
}, meta.CreateOptions{}); err != nil {
t.Fatal(err)
}