TrueCloudLab/coredns
16
0
Fork 2
Code Issues Pull requests 1 Projects Releases Packages Wiki Activity Actions

Speed up testing (#4239)

Browse source 
* Speed up testing

* make notification run in the background, this recudes the test_readme
time from 18s to 0.10s
* reduce time for zone reload

* TestServeDNSConcurrent remove entirely. This took a whopping 58s for
  ... ? A few minutes staring didn't reveal wth it is actually testing.
  Making values smaller revealed race conditions in the tests. Remove
  entirely.

* Move many interval values to variables so we can reset them to short
  values for the tests.

* test_large_axfr: make the zone smaller. The number used 64K has no
  rational, make it 64/10 to speed up.
* TestProxyThreeWay: use client with shorter timeout

A few random tidbits in other tests.

Total time saved: 177s (almost 3m) - which makes it worthwhile again to
run the test locally:

this branch:

~~~
ok  	github.com/coredns/coredns/test	10.437s
cd plugin; time go t ./...
5,51s user 7,51s system 11,15s elapsed 744%CPU (
~~~

master:

~~~
ok  	github.com/coredns/coredns/test	35.252s
cd plugin; time go t ./...
157,64s user 15,39s system 50,05s elapsed 345%CPU ()
~~~
tests/ -25s
plugins/ -40s

This brings the total on 20s, and another 10s can be saved by fixing
dnstapio. Moving this to 5s would be even better, but 10s is also nice.

Signed-off-by: Miek Gieben <miek@miek.nl>

* Also 0.01

Signed-off-by: Miek Gieben <miek@miek.nl>
This commit is contained in:
Miek Gieben 2020-10-30 10:27:04 +01:00 • committed by GitHub
parent bc0115d71f
commit c840caf1ef
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
15 changed files with 85 additions and 285 deletions
Download patch file Download diff file Expand all files Collapse all files

6
plugin/file/reload_test.go
View file

@ -30,9 +30,9 @@ func TestZoneReload(t *testing.T) {
t.Fatalf("Failed to parse zone: %s", err)
}
z.ReloadInterval = 500 * time.Millisecond
z.ReloadInterval = 10 * time.Millisecond
z.Reload(&transfer.Transfer{})
time.Sleep(time.Second)
time.Sleep(20 * time.Millisecond)
ctx := context.TODO()
r := new(dns.Msg)
@ -60,7 +60,7 @@ func TestZoneReload(t *testing.T) {
t.Fatalf("Failed to write new zone data: %s", err)
}
// Could still be racy, but we need to wait a bit for the event to be seen
time.Sleep(1 * time.Second)
time.Sleep(30 * time.Millisecond)
rrs, err = z.ApexIfDefined()
if err != nil {