From c86be3428a2b4adc3e5d76aafe1a306ae6bb7f07 Mon Sep 17 00:00:00 2001 From: Oleg Atamanenko Date: Thu, 23 Jul 2020 00:40:17 -0700 Subject: [PATCH] Disable debug mode for tracing - removes extra logging (#4016) Signed-off-by: Oleg Atamanenko --- plugin/trace/README.md | 5 +++++ plugin/trace/trace.go | 3 ++- 2 files changed, 7 insertions(+), 1 deletion(-) diff --git a/plugin/trace/README.md b/plugin/trace/README.md index 31e74ea71..3c36f0b86 100644 --- a/plugin/trace/README.md +++ b/plugin/trace/README.md @@ -7,6 +7,7 @@ ## Description With *trace* you enable OpenTracing of how a request flows through CoreDNS. +Enable *debug* plugin to get logs from the trace plugin. ## Syntax @@ -84,3 +85,7 @@ trace tracinghost:9411 { client_server } ~~~ + +## Also See + +See the *debug* plugin for more information about debug logging. diff --git a/plugin/trace/trace.go b/plugin/trace/trace.go index 63b2248fd..84076126a 100644 --- a/plugin/trace/trace.go +++ b/plugin/trace/trace.go @@ -10,6 +10,7 @@ import ( "github.com/coredns/coredns/plugin" "github.com/coredns/coredns/plugin/metrics" "github.com/coredns/coredns/plugin/pkg/dnstest" + "github.com/coredns/coredns/plugin/pkg/log" "github.com/coredns/coredns/plugin/pkg/rcode" _ "github.com/coredns/coredns/plugin/pkg/trace" // Plugin the trace package. "github.com/coredns/coredns/request" @@ -52,7 +53,7 @@ func (t *trace) OnStartup() error { case "zipkin": err = t.setupZipkin() case "datadog": - tracer := opentracer.New(tracer.WithAgentAddr(t.Endpoint), tracer.WithServiceName(t.serviceName), tracer.WithDebugMode(true)) + tracer := opentracer.New(tracer.WithAgentAddr(t.Endpoint), tracer.WithServiceName(t.serviceName), tracer.WithDebugMode(log.D.Value())) t.tracer = tracer default: err = fmt.Errorf("unknown endpoint type: %s", t.EndpointType)