From cd5dcebe9352b6a08687cfdf3ac8115bd7c8dfcc Mon Sep 17 00:00:00 2001 From: Miek Gieben Date: Wed, 31 Jul 2019 18:18:49 +0000 Subject: [PATCH] core: log panics (#3072) These are too hidden now. They increase the issue-load, because people don't see them. Add log.Errorf in the core/dnsserver recover routine. Signed-off-by: Miek Gieben --- core/dnsserver/server.go | 1 + 1 file changed, 1 insertion(+) diff --git a/core/dnsserver/server.go b/core/dnsserver/server.go index 558954304..4a143f9b3 100644 --- a/core/dnsserver/server.go +++ b/core/dnsserver/server.go @@ -200,6 +200,7 @@ func (s *Server) ServeDNS(ctx context.Context, w dns.ResponseWriter, r *dns.Msg) // In case the user doesn't enable error plugin, we still // need to make sure that we stay alive up here if rec := recover(); rec != nil { + log.Errorf("Recovered from panic in server: %q", s.Addr) vars.Panic.Inc() errorAndMetricsFunc(s.Addr, w, r, dns.RcodeServerFailure) }