TrueCloudLab/coredns
16
0
Fork 2
Code Issues Pull requests 1 Projects Releases Packages Wiki Activity Actions

Don't error log NXDOMAIN (#572)

Browse source 
In both etcd and k8s don't error log NXDOMAIN as this log spams the logs
for no good reason.

Fixes #568

Better long term solution is log rate limiting for both *log* and
*error*.
This commit is contained in:
Miek Gieben 2017-03-06 11:43:23 +00:00 • committed by GitHub
parent 12678ac5e2
commit d1bb4ea130
2 changed files with 4 additions and 2 deletions
Download patch file Download diff file Expand all files Collapse all files

3
middleware/etcd/handler.go
View file

@ -89,7 +89,8 @@ func (e *Etcd) ServeDNS(ctx context.Context, w dns.ResponseWriter, r *dns.Msg) (
} }
if e.IsNameError(err) { if e.IsNameError(err) {
return middleware.BackendError(e, zone, dns.RcodeNameError, state, debug, err, opt) // Make err nil when returning here, so we don't log spam for NXDOMAIN.
return middleware.BackendError(e, zone, dns.RcodeNameError, state, debug, nil /* err */, opt)
} }
if err != nil { if err != nil {
return middleware.BackendError(e, zone, dns.RcodeServerFailure, state, debug, err, opt) return middleware.BackendError(e, zone, dns.RcodeServerFailure, state, debug, err, opt)

3
middleware/kubernetes/handler.go
View file

@ -71,7 +71,8 @@ func (k Kubernetes) ServeDNS(ctx context.Context, w dns.ResponseWriter, r *dns.M
_, _, err = middleware.A(&k, zone, state, nil, middleware.Options{}) _, _, err = middleware.A(&k, zone, state, nil, middleware.Options{})
} }
if k.IsNameError(err) { if k.IsNameError(err) {
return middleware.BackendError(&k, zone, dns.RcodeNameError, state, nil /*debug*/, err, middleware.Options{}) // Make err nil when returning here, so we don't log spam for NXDOMAIN.
return middleware.BackendError(&k, zone, dns.RcodeNameError, state, nil /*debug*/, nil /* err */, middleware.Options{})
} }
if err != nil { if err != nil {
return dns.RcodeServerFailure, err return dns.RcodeServerFailure, err