TrueCloudLab/coredns
16
0
Fork 2
Code Issues Pull requests 1 Projects Releases Packages Wiki Activity Actions

pkg/log: reset the buffer in the tests (#2828)

Browse source 
Reset the buf otherwise we're not checking the new value.

Signed-off-by: Miek Gieben <miek@miek.nl>
This commit is contained in:
Miek Gieben 2019-05-18 09:08:34 +01:00 • committed by GitHub
parent 2ef55f805e
commit d41e9ff7b7
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
1 changed files with 4 additions and 0 deletions
Download patch file Download diff file Expand all files Collapse all files

4
plugin/pkg/log/log_test.go
View file

@ -16,6 +16,7 @@ func TestDebug(t *testing.T) {
if x := f.String(); x != "" { if x := f.String(); x != "" {
t.Errorf("Expected no debug logs, got %s", x) t.Errorf("Expected no debug logs, got %s", x)
} }
f.Reset()
D = true D = true
Debug("debug") Debug("debug")
@ -34,6 +35,7 @@ func TestDebugx(t *testing.T) {
if x := f.String(); !strings.Contains(x, debug+"debug") { if x := f.String(); !strings.Contains(x, debug+"debug") {
t.Errorf("Expected debug log to be %s, got %s", debug+"debug", x) t.Errorf("Expected debug log to be %s, got %s", debug+"debug", x)
} }
f.Reset()
Debug("debug") Debug("debug")
if x := f.String(); !strings.Contains(x, debug+"debug") { if x := f.String(); !strings.Contains(x, debug+"debug") {
@ -50,10 +52,12 @@ func TestLevels(t *testing.T) {
if x := f.String(); !strings.Contains(x, info+ts) { if x := f.String(); !strings.Contains(x, info+ts) {
t.Errorf("Expected log to be %s, got %s", info+ts, x) t.Errorf("Expected log to be %s, got %s", info+ts, x)
} }
f.Reset()
Warning(ts) Warning(ts)
if x := f.String(); !strings.Contains(x, warning+ts) { if x := f.String(); !strings.Contains(x, warning+ts) {
t.Errorf("Expected log to be %s, got %s", warning+ts, x) t.Errorf("Expected log to be %s, got %s", warning+ts, x)
} }
f.Reset()
Error(ts) Error(ts)
if x := f.String(); !strings.Contains(x, err+ts) { if x := f.String(); !strings.Contains(x, err+ts) {
t.Errorf("Expected log to be %s, got %s", err+ts, x) t.Errorf("Expected log to be %s, got %s", err+ts, x)