TrueCloudLab/coredns
16
0
Fork 2
Code Issues Pull requests 1 Projects Releases Packages Wiki Activity Actions

Add bufsize plugin for preparing the DNS Flag Day and avoiding IP fragmentation (#3401)

Browse source 
* add bufsize plugin

Signed-off-by: ykhr53 <yukihira.lab@gmail.com>

* add docstring and comment

Signed-off-by: ykhr53 <yukihira.lab@gmail.com>

* delete stdout messages when get an error

Signed-off-by: ykhr53 <yukihira.lab@gmail.com>

* change to context.Background from TODO

Signed-off-by: ykhr53 <yukihira.lab@gmail.com>

* define default bufsize as defaultBufSize constant

Signed-off-by: ykhr53 <yukihira.lab@gmail.com>

* fix some comments

Signed-off-by: ykhr53 <yukihira.lab@gmail.com>

* function name change: parse

Signed-off-by: ykhr53 <yukihira.lab@gmail.com>

* function name change: parse

Signed-off-by: ykhr53 <yukihira.lab@gmail.com>
This commit is contained in:
Kohei Yoshida 2019-11-10 08:10:12 +00:00 • committed by Miek Gieben
parent 113783ed91
commit e23a34abb4
8 changed files with 234 additions and 0 deletions
Download patch file Download diff file Expand all files Collapse all files

46
plugin/bufsize/setup_test.go Normal file
View file

@ -0,0 +1,46 @@
package bufsize
import (
"strings"
"testing"
"github.com/caddyserver/caddy"
)
func TestSetupBufsize(t *testing.T) {
tests := []struct {
input string
shouldErr bool
expectedData int
expectedErrContent string // substring from the expected error. Empty for positive cases.
}{
{`bufsize`, false, 512, ""},
{`bufsize "1232"`, false, 1232, ""},
{`bufsize "5000"`, true, -1, "plugin"},
{`bufsize "512 512"`, true, -1, "plugin"},
{`bufsize "abc123"`, true, -1, "plugin"},
}
for i, test := range tests {
c := caddy.NewTestController("dns", test.input)
bufsize, err := parse(c)
if test.shouldErr && err == nil {
t.Errorf("Test %d: Expected error but found %s for input %s", i, err, test.input)
}
if err != nil {
if !test.shouldErr {
t.Errorf("Test %d: Error found for input %s. Error: %v", i, test.input, err)
}
if !strings.Contains(err.Error(), test.expectedErrContent) {
t.Errorf("Test %d: Expected error to contain: %v, found error: %v, input: %s", i, test.expectedErrContent, err, test.input)
}
}
if !test.shouldErr && bufsize != test.expectedData {
t.Errorf("Test %d: Bufsize not correctly set for input %s. Expected: %d, actual: %d", i, test.input, test.expectedData, bufsize)
}
}
}