TrueCloudLab/coredns
16
0
Fork 2
Code Issues Pull requests 1 Projects Releases Packages Wiki Activity Actions

plugin/k8s_external: Set authoritative bit in responses (#5284)

Browse source 
set authoritative bit in responses

Signed-off-by: Chris O'Haver <cohaver@infoblox.com>
This commit is contained in:
Chris O'Haver 2022-04-12 11:01:15 -04:00 • committed by GitHub
parent 83021637b3
commit e60c179194
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
4 changed files with 9 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
plugin/k8s_external/apex.go
View file

@ -11,6 +11,7 @@ import (
func (e *External) serveApex(state request.Request) (int, error) { func (e *External) serveApex(state request.Request) (int, error) {
m := new(dns.Msg) m := new(dns.Msg)
m.SetReply(state.Req) m.SetReply(state.Req)
m.Authoritative = true
switch state.QType() { switch state.QType() {
case dns.TypeSOA: case dns.TypeSOA:
m.Answer = []dns.RR{e.soa(state)} m.Answer = []dns.RR{e.soa(state)}
@ -37,6 +38,7 @@ func (e *External) serveSubApex(state request.Request) (int, error) {
m := new(dns.Msg) m := new(dns.Msg)
m.SetReply(state.Req) m.SetReply(state.Req)
m.Authoritative = true
// base is either dns. of ns1.dns (or another name), if it's longer return nxdomain // base is either dns. of ns1.dns (or another name), if it's longer return nxdomain
switch labels := dns.CountLabel(base); labels { switch labels := dns.CountLabel(base); labels {

3
plugin/k8s_external/apex_test.go
View file

@ -41,6 +41,9 @@ func TestApex(t *testing.T) {
if resp == nil { if resp == nil {
t.Fatalf("Test %d, got nil message and no error for %q", i, r.Question[0].Name) t.Fatalf("Test %d, got nil message and no error for %q", i, r.Question[0].Name)
} }
if !resp.Authoritative {
t.Error("Expected authoritative answer")
}
if err := test.SortAndCheck(resp, tc); err != nil { if err := test.SortAndCheck(resp, tc); err != nil {
t.Error(err) t.Error(err)
} }

1
plugin/k8s_external/external.go
View file

@ -89,6 +89,7 @@ func (e *External) ServeDNS(ctx context.Context, w dns.ResponseWriter, r *dns.Ms
m := new(dns.Msg) m := new(dns.Msg)
m.SetReply(state.Req) m.SetReply(state.Req)
m.Authoritative = true
if len(svc) == 0 { if len(svc) == 0 {
m.Rcode = rcode m.Rcode = rcode

3
plugin/k8s_external/external_test.go
View file

@ -45,6 +45,9 @@ func TestExternal(t *testing.T) {
if resp == nil { if resp == nil {
t.Fatalf("Test %d, got nil message and no error for %q", i, r.Question[0].Name) t.Fatalf("Test %d, got nil message and no error for %q", i, r.Question[0].Name)
} }
if !resp.Authoritative {
t.Error("Expected authoritative answer")
}
if err = test.SortAndCheck(resp, tc); err != nil { if err = test.SortAndCheck(resp, tc); err != nil {
t.Error(err) t.Error(err)
} }