pkg/typify: empty messages are OtherError (#1531)

Messages with nothing in them are considered OtherError, they can not
serve any purpose for normal clients (i.e. dyn update or notifies might
have a use for them).

Also update a test in the cache plugin, so that we explicitaly test for
this case.
This commit is contained in:
Miek Gieben 2018-02-16 09:43:22 +01:00 committed by GitHub
parent f10627c1d6
commit fc1d73ffa9
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
4 changed files with 35 additions and 1 deletions

View file

@ -171,7 +171,7 @@ func (w *ResponseWriter) set(m *dns.Msg, key int, mt response.Type, duration tim
case response.OtherError:
// don't cache these
default:
log.Printf("[WARNING] Caching called with unknown classification: %d", mt)
log.Printf("[WARNING] Caching called with unknown typification: %d", mt)
}
}