TrueCloudLab/coredns
16
0
Fork 2
Code Issues Pull requests 1 Projects Releases Packages Wiki Activity Actions

Golint (#386)

Browse source 
Lint and vet the curret code add docs about adding a git post-commit
hook that performs these actions after each commit.
This commit is contained in:
Miek Gieben 2016-11-07 07:43:38 +00:00 • committed by GitHub
parent d3dae8d77f
commit fc85754849
3 changed files with 50 additions and 18 deletions
Download patch file Download diff file Expand all files Collapse all files

24
middleware/file/tree/print.go
View file

@ -11,20 +11,20 @@ func (t *Tree) Print() {
}
func (n *Node) print() {
q := NewQueue()
q.Push(n)
q := newQueue()
q.push(n)
nodesInCurrentLevel := 1
nodesInNextLevel := 0
for !q.Empty() {
do := q.Pop()
for !q.empty() {
do := q.pop()
nodesInCurrentLevel--
if do != nil {
fmt.Print(do.Elem.Name(), " ")
q.Push(do.Left)
q.Push(do.Right)
q.push(do.Left)
q.push(do.Right)
nodesInNextLevel += 2
}
if nodesInCurrentLevel == 0 {
@ -38,21 +38,25 @@ func (n *Node) print() {
type queue []*Node
func NewQueue() queue {
// newQueue returns a new queue.
func newQueue() queue {
q := queue([]*Node{})
return q
}
func (q *queue) Push(n *Node) {
// push pushes n to the end of the queue.
func (q *queue) push(n *Node) {
*q = append(*q, n)
}
func (q *queue) Pop() *Node {
// pop pops the first element off the queue.
func (q *queue) pop() *Node {
n := (*q)[0]
*q = (*q)[1:]
return n
}
func (q *queue) Empty() bool {
// empty returns true when the queue containes zero nodes.
func (q *queue) empty() bool {
return len(*q) == 0
}

12
middleware/kubernetes/controller.go
View file

@ -83,12 +83,12 @@ func serviceListFunc(c *kubernetes.Clientset, ns string, s *labels.Selector) fun
if s != nil {
opts.LabelSelector = *s
}
list_v1, err := c.Core().Services(ns).List(opts)
listV1, err := c.Core().Services(ns).List(opts)
if err != nil {
return nil, err
}
var list_api api.ServiceList
err = v1.Convert_v1_ServiceList_To_api_ServiceList(list_v1, &list_api, nil)
var listAPI api.ServiceList
err = v1.Convert_v1_ServiceList_To_api_ServiceList(listV1, &listAPI, nil)
if err != nil {
return nil, err
}
@ -110,12 +110,12 @@ func namespaceListFunc(c *kubernetes.Clientset, s *labels.Selector) func(api.Lis
if s != nil {
opts.LabelSelector = *s
}
list_v1, err := c.Core().Namespaces().List(opts)
listV1, err := c.Core().Namespaces().List(opts)
if err != nil {
return nil, err
}
var list_api api.NamespaceList
err = v1.Convert_v1_NamespaceList_To_api_NamespaceList(list_v1, &list_api, nil)
var listAPI api.NamespaceList
err = v1.Convert_v1_NamespaceList_To_api_NamespaceList(listV1, &listAPI, nil)
if err != nil {
return nil, err
}