Commit graph

1271 commits

Author SHA1 Message Date
Chris O'Haver
05751bdb59
register HealthcheckBrokenCount (#4021)
Signed-off-by: Chris O'Haver <cohaver@infoblox.com>
2020-07-24 08:28:18 -04:00
Oleg Atamanenko
c86be3428a
Disable debug mode for tracing - removes extra logging (#4016)
Signed-off-by: Oleg Atamanenko <oleg.atamanenko@gmail.com>
2020-07-23 09:40:17 +02:00
Ricardo Katz
3ebb46320a
Improve gRPC Plugin when backend is not available (#3966)
* Improve gRPC Plugin when backend is not available

Signed-off-by: Ricardo Pchevuzinske Katz <ricardo.katz@serpro.gov.br>

* Improve gRPC Plugin when backend is not available

Signed-off-by: Ricardo Pchevuzinske Katz <ricardo.katz@serpro.gov.br>
2020-07-15 19:59:45 +02:00
Zou Nengren
20c4f28a5c
remove TestProxyClose (#4005)
Signed-off-by: zounengren <zounengren@cmss.chinamobile.com>
2020-07-13 08:26:43 -07:00
Yong Tang
614d08cba2
Revert "Implement notifies for transfer plugin (#3972)" (#3995)
This reverts commit 68f1dd5ddf.

Signed-off-by: Yong Tang <yong.tang.github@outlook.com>
2020-07-08 09:00:26 -07:00
Miek Gieben
68f1dd5ddf
Implement notifies for transfer plugin (#3972)
* Fix notifies in transfer plugin

Signed-off-by: Miek Gieben <miek@miek.nl>

* Make it compile

Signed-off-by: Miek Gieben <miek@miek.nl>

* Port more plugins

Signed-off-by: Miek Gieben <miek@miek.nl>

* golint

Signed-off-by: Miek Gieben <miek@miek.nl>

* Fix tests

Signed-off-by: Miek Gieben <miek@miek.nl>

* Fix notifies in transfer plugin

Signed-off-by: Miek Gieben <miek@miek.nl>

* Make it compile

Signed-off-by: Miek Gieben <miek@miek.nl>

* Port more plugins

Signed-off-by: Miek Gieben <miek@miek.nl>

* golint

Signed-off-by: Miek Gieben <miek@miek.nl>

* Fix tests

Signed-off-by: Miek Gieben <miek@miek.nl>

* Fix tests

Signed-off-by: Miek Gieben <miek@miek.nl>

* really fix test

Signed-off-by: Miek Gieben <miek@miek.nl>

* Implement ixfr fallback and unify file and auto for transfering

Signed-off-by: Miek Gieben <miek@miek.nl>

* Add transfer tests

copied and modified from #3452

Signed-off-by: Miek Gieben <miek@miek.nl>

* Test correct selection of plugin

Signed-off-by: Miek Gieben <miek@miek.nl>

* add upstream back in

Signed-off-by: Miek Gieben <miek@miek.nl>

* Implement ixfr fallback and unify file and auto for transfering

Signed-off-by: Miek Gieben <miek@miek.nl>

* fix test

Signed-off-by: Miek Gieben <miek@miek.nl>

* properly merge

Signed-off-by: Miek Gieben <miek@miek.nl>
2020-07-07 12:38:07 -07:00
Zou Nengren
41f9142dd2
complete nsid plugin test case (#3981)
Signed-off-by: zounengren <zounengren@cmss.chinamobile.com>
2020-07-01 10:17:26 +02:00
Zou Nengren
5437370734
complete transfer plugin test case (#3967)
Signed-off-by: zounengren <zounengren@cmss.chinamobile.com>
2020-06-29 12:02:56 -07:00
Chris O'Haver
47d6e86f58
plugin/cache/forward: Clean up grammar/wording in forward & cache metrics descriptions. (#3971)
* tweak language

Signed-off-by: Chris O'Haver <cohaver@infoblox.com>

* tweak language

Signed-off-by: Chris O'Haver <cohaver@infoblox.com>

* typo

Signed-off-by: Chris O'Haver <cohaver@infoblox.com>
2020-06-24 07:49:42 -07:00
Miek Gieben
55e9c2cd7b
plugin/forward: remove exp backoff stuff (#3970)
we hc every 0.5s, doing exp backoff will create a large gap in the
ability to re-use an upstream. Doing a exp. backoff up to (say) 3s,
isn't really exp backoff either.

Remove the wording from the documentation.

Signed-off-by: Miek Gieben <miek@miek.nl>
2020-06-24 07:49:06 -07:00
Zou Nengren
8647592786
format and add newline (#3969)
Signed-off-by: zounengren <zounengren@cmss.chinamobile.com>
2020-06-24 07:48:39 -07:00
Zou Nengren
73e927d6a8
completed metrics of cache and forward (#3962)
Signed-off-by: zounengren <zounengren@cmss.chinamobile.com>
2020-06-24 06:54:03 +02:00
Zou Nengren
55a33aa9d2
add test case of remote ip (#3964)
Signed-off-by: zounengren <zounengren@cmss.chinamobile.com>
2020-06-23 14:37:00 -07:00
Ben Kochie
7504b410f3
Update dns64 plugin bugs list (#3955)
Remove the "Follow CNAMEs" bug, CNAME following is handled by the
forward plugin.

Signed-off-by: Ben Kochie <superq@gmail.com>
2020-06-20 07:01:35 -07:00
Chris O'Haver
d902e85919
plugin/kubernetes: fix tombstone unwrapping (#3924)
* fix tombstone unwrapping

Signed-off-by: Chris O'Haver <cohaver@infoblox.com>
2020-06-15 10:15:41 -04:00
Yang Bo
4734c0db45
weight for SRV records should be at least 1 (#3931)
Automatically submitted.
2020-06-12 06:01:28 +00:00
Daisuke TASAKI
f3e6575654
plugin/azure: Fix environment option (#3922)
* environment option overwrites a client secret

Signed-off-by: Daisuke TASAKI <tasaki@i3-systems.com>
2020-06-04 15:30:11 +02:00
Michael Kashin
2e3ef77731
k8s_external can now resolve CNAME returned by AWS ELB/NLB (#3916)
Automatically submitted.
2020-05-29 17:04:23 +00:00
Chris O'Haver
54fb2112ac
plugin/forward/grpc: Revert forward/grpc policy dedup (#3919)
* revert de-dup

Signed-off-by: Chris O'Haver <cohaver@infoblox.com>

* unit test

Signed-off-by: Chris O'Haver <cohaver@infoblox.com>

* use roundrobin policy in test

Signed-off-by: Chris O'Haver <cohaver@infoblox.com>
2020-05-29 18:30:26 +02:00
Chris O'Haver
a3aeb3d503
plugin/kubernetes: handle tombstones in default processor (#3890)
* handle deletion tombstones in default processor

Signed-off-by: Chris O'Haver <cohaver@infoblox.com>

* fix terminating pod exclusion

Signed-off-by: Chris O'Haver <cohaver@infoblox.com>
2020-05-15 09:47:29 -07:00
Chris O'Haver
bb7ee5010e
plugin/kubernetes: Handle endpoint tombstones (#3887)
* check for nil

Signed-off-by: Chris O'Haver <cohaver@infoblox.com>

* handle tombstone

Signed-off-by: Chris O'Haver <cohaver@infoblox.com>

* move casting to caller. add comments.

Signed-off-by: Chris O'Haver <cohaver@infoblox.com>

* more sanding

Signed-off-by: Chris O'Haver <cohaver@infoblox.com>

* more scrubbing

Signed-off-by: Chris O'Haver <cohaver@infoblox.com>

* move object unwraping to switch cases

Signed-off-by: Chris O'Haver <cohaver@infoblox.com>

* oops remove debug

Signed-off-by: Chris O'Haver <cohaver@infoblox.com>

* remove cruft

Signed-off-by: Chris O'Haver <cohaver@infoblox.com>
2020-05-14 12:39:40 -07:00
Chris O'Haver
f4cb9a1ba3
fix readme (#3889)
Signed-off-by: Chris O'Haver <cohaver@infoblox.com>
2020-05-14 09:58:58 -07:00
Miek Gieben
7aaed71b92
Fix query for SOA record for delegated zone (#3875)
Addresses a bug in the file plugin where SOA queries to zone delegations are
inappropriately returned the SOA for the delegating zone, and not a downward
referral to the delegated zone.

Here is an example of what I believe the expected downward referral in response
to a SOA query for a delegated zone should be (note that no SOA record is
returned):

~~~
; <<>> DiG 9.11.3-1ubuntu1.5-Ubuntu <<>> @k.root-servers.net. miek.nl. SOA
; (2 servers found)
;; global options: +cmd
;; Got answer:
;; ->>HEADER<<- opcode: QUERY, status: NOERROR, id: 58381
;; flags: qr rd; QUERY: 1, ANSWER: 0, AUTHORITY: 3, ADDITIONAL: 7
;; WARNING: recursion requested but not available

;; OPT PSEUDOSECTION:
; EDNS: version: 0, flags:; udp: 4096
;; QUESTION SECTION:
;miek.nl.                       IN      SOA

;; AUTHORITY SECTION:
nl.                     172800  IN      NS      ns1.dns.nl.
nl.                     172800  IN      NS      ns2.dns.nl.
nl.                     172800  IN      NS      ns3.dns.nl.

;; ADDITIONAL SECTION:
ns1.dns.nl.             172800  IN      A       194.0.28.53
ns2.dns.nl.             172800  IN      A       194.146.106.42
ns3.dns.nl.             172800  IN      A       194.0.25.24
ns1.dns.nl.             172800  IN      AAAA    2001:678:2c:0:194:0:28:53
ns2.dns.nl.             172800  IN      AAAA    2001:67c:1010:10::53
ns3.dns.nl.             172800  IN      AAAA    2001:678:20::24
~~~

See #3852 for the original fix.

Modified clouddns/route53 and removed the faulty tests there.

Signed-off-by: Miek Gieben <miek@miek.nl>
2020-05-11 07:51:02 -07:00
Catena cyber
886cdd9dd3
Fix plugin forward fuzz target (#3877)
using new method to start proxies

Signed-off-by: Philippe Antoine <contact@catenacyber.fr>
2020-05-07 10:24:00 +02:00
Chris O'Haver
5897a7c03d
plugin/kubernetes: Mention remote IP requirement for autopath and metadata in README (#3876)
* mention remote IP requirement for autopath and metadata

Signed-off-by: Chris O'Haver <cohaver@infoblox.com>

* remove whitespace

Signed-off-by: Chris O'Haver <cohaver@infoblox.com>
2020-05-06 09:07:14 -07:00
Chris O'Haver
7c7772b735
always add client metadata (#3874)
Signed-off-by: Chris O'Haver <cohaver@infoblox.com>
2020-05-05 11:34:24 -07:00
Eli Lindsey
9f9509b6c0
fix description of bufsize plugin (#3873)
Signed-off-by: Eli Lindsey <eli@siliconsprawl.com>
2020-05-04 07:02:58 -07:00
Chris O'Haver
a5e286ac4e
plugin/kubernetes: Don't panic with metadata enabled and pods mode not verified (#3869)
* prevent panic in podWithIP

Signed-off-by: Chris O'Haver <cohaver@infoblox.com>

* add unit test, correct existing unit test

Signed-off-by: Chris O'Haver <cohaver@infoblox.com>

* unit tests make more sense this way

Signed-off-by: Chris O'Haver <cohaver@infoblox.com>
2020-05-04 10:17:26 +02:00
Krzysztof Dąbrowski
5347bc38e7
Fix CIDR in example (#3864)
Signed-off-by: Krzysztof Dąbrowski <krzysdabro@live.com>
2020-04-28 10:46:20 -04:00
Erfan Besharat
dcdbec53e4
Fix NSID not being set on cached responses (#3822)
* Add NSID to the cached responses

Signed-off-by: Erfan Besharat <erbesharat@gmail.com>

* Add test for NSID being set on cached responses

Signed-off-by: Erfan Besharat <erbesharat@gmail.com>
2020-04-27 08:49:56 -07:00
Miek Gieben
840e875665
Run go generate (#3856)
@zouyee has added himself to CODEOWNERS, run go generate to update
the author list for the chaos plugin.

Signed-off-by: Miek Gieben <miek@miek.nl>
2020-04-27 10:38:44 +02:00
Chris O'Haver
74eabe90e0
not implemented yet (#3851)
Automatically submitted.
2020-04-24 05:50:29 +00:00
Yong Tang
180a6709a8
Fix readme test by removing extra ~ (#3850)
This PR removing extra `~` as it was causing test failure:
```
--- FAIL: TestReadme (0.05s)
476    readme_test.go:81: Failed to start server with ../plugin/dns64/README.md, for input "Corefile:6 - Error during parsing: Unknown directive 'Or'":
477        . {
478            dns64 64:1337::/96
479        }
480        ~~~~
481
482        Or
483        . {
484            dns64 {
485                prefix 64:1337::/96
486            }
487        }
488FAIL
```

Signed-off-by: Yong Tang <yong.tang.github@outlook.com>
2020-04-23 21:03:15 -04:00
Miek Gieben
ec5696b202
plugin/dns64: update readme and owners (#3848)
* plugin/dns64: update readme and owners

Make @superq code owner of the plugins. Update the readme a bit:

* don't make it start with a quote
* make it look more like other README's in syntax description
* make a full corefile examples and tests these by setting the corefile
  language tag

Signed-off-by: Miek Gieben <miek@miek.nl>

* Update plugin/dns64/README.md

Co-Authored-By: Ben Kochie <superq@gmail.com>

* Update plugin/dns64/README.md

Co-Authored-By: Ben Kochie <superq@gmail.com>

* Update plugin/dns64/README.md

Co-Authored-By: Ben Kochie <superq@gmail.com>

* Update plugin/dns64/README.md

Co-Authored-By: Ben Kochie <superq@gmail.com>

* Update plugin/dns64/README.md

Co-Authored-By: Ben Kochie <superq@gmail.com>

Co-authored-by: Ben Kochie <superq@gmail.com>
2020-04-23 10:22:20 +02:00
Mirek S
8fe950f4bc
Fix to: (#3840)
https://github.com/coredns/coredns/issues/3810

Signed-off-by: msedzins <msedzins@gmail.com>
Signed-off-by: msedzins <macbookpro@mbp-macbookpro-2.home>

Co-authored-by: msedzins <macbookpro@mbp-macbookpro-2.home>
2020-04-22 14:55:07 +02:00
Tobias Schmidt
8013925b53
Remove grobie from maintainers (#3833)
I haven't been maintaining production DNS setups in quite a while and
don't have the time to review CoreDNS pull requests. Hereby I resign
from all positions in the CoreDNS project.

CoreDNS is a great project and SoundCloud still processes hundreds of
thousands of requests per second with the help of CoreDNS. Thanks a lot
for your hard work and all the best for the future.

Signed-off-by: Tobias Schmidt <tobidt@gmail.com>
2020-04-15 10:07:10 +02:00
Zou Nengren
c639615615
remove ignored option at kubernetes plugin (#3737)
Signed-off-by: zounengren <zounengren@cmss.chinamobile.com>
2020-04-14 09:03:18 -04:00
kadern0
e410760a49
plugin/forward: crash if using https (#3817)
Signed-off-by: kadern0 <kaderno@gmail.com>
2020-04-09 11:26:28 -07:00
Zou Nengren
4ccd55e95e
correct metrics name of cache size (#3805)
Signed-off-by: zounengren <zounengren@cmss.chinamobile.com>
2020-04-03 09:30:06 -07:00
Ben Kochie
a29a594e5c
Update more metrics names (#3799)
The subsystem of a metric must be it's plugin name. "dns" is reserved
for the core. Use a const convention to avoid copy-paste mistakes in
naming.

Fix dns64 and acl plugin.

Signed-off-by: Ben Kochie <superq@gmail.com>
2020-03-31 20:03:18 +02:00
Zou Nengren
87214a4c5c
introduce metric naming test (#3789)
* introduce metric naming test

Signed-off-by: zounengren <zounengren@cmss.chinamobile.com>

* Update metrics.go

Signed-off-by: zounengren <zounengren@cmss.chinamobile.com>
2020-03-31 08:07:36 +02:00
Yong Tang
ebbfffaf9d
Update k8s.io/[api|apimachinery|client-go] to v0.18.0 (#3796)
* Update k8s.io/[api|apimachinery|client-go] to v0.18.0

This PR updates k8s.io/[api|apimachinery|client-go] to v0.18.0

This PR closes 3791
This PR closes 3792
This PR closes 3793

Signed-off-by: Yong Tang <yong.tang.github@outlook.com>

* Fix test failures

Signed-off-by: Yong Tang <yong.tang.github@outlook.com>

* Fix failed tests

Signed-off-by: Yong Tang <yong.tang.github@outlook.com>

* Fix test failure

Signed-off-by: Yong Tang <yong.tang.github@outlook.com>
2020-03-30 11:10:41 -07:00
Zou Nengren
8bbfa19223
remove federation (#3794)
Signed-off-by: zounengren <zounengren@cmss.chinamobile.com>
2020-03-30 09:08:20 -07:00
Zou Nengren
fa1e909d0b
regitry reload metrics (#3784)
Signed-off-by: zounengren <zounengren@cmss.chinamobile.com>
2020-03-27 09:40:59 +01:00
Chris O'Haver
5cd8472384
Fix plugin name in project README (#3683)
* Update README.md

Signed-off-by: Chris O'Haver <cohaver@infoblox.com>

* fix readme occurances

Signed-off-by: Chris O'Haver <cohaver@infoblox.com>
2020-03-26 10:24:56 -04:00
Ben Kochie
14ca454981
Documentation improvements for dns64 plugin (#3777)
Minor typo and improvements to the dns64 plugin README.

Signed-off-by: Ben Kochie <superq@gmail.com>
2020-03-26 09:22:29 +01:00
Miek Gieben
19cfa2960c
Cleanup metrics (#3776)
Cleanup a variety of metric issues.
* Eliminate department of redundancy "count_total" naming.
* Use the plural of the unit when appropriate. (ex, "requests")
* Remove label names from metric names where appropriate. (ex, "rcode")
* Simplify request metrics by consolidating type label in to the base
request counter.
* Re-generate man pages.

Signed-off-by: Ben Kochie <superq@gmail.com>

Co-authored-by: Ben Kochie <superq@gmail.com>
2020-03-26 09:17:33 +01:00
Chris O'Haver
eb23cce1a7
add known issue (#3770)
Signed-off-by: Chris O'Haver <cohaver@infoblox.com>
2020-03-26 08:42:32 +01:00
Ben Kochie
4eeaef29ea
Add dns64 plugin (#3534)
* Add dns64 plugin

Add external plugin to core in-tree.
* Pull code from upstream: https://github.com/serverwentdown/dns64
* Update docs.

Signed-off-by: Ben Kochie <superq@gmail.com>

* Make dns64 consistent.

Signed-off-by: Ben Kochie <superq@gmail.com>

* Cleanup README

Signed-off-by: Ben Kochie <superq@gmail.com>

* Cleanup minor issues.

Signed-off-by: Ben Kochie <superq@gmail.com>

* Remove proxy method.

Signed-off-by: Ben Kochie <superq@gmail.com>

* dns64: big cleanup

* Make the code a bit more idiomatic
* Add tests
* use proper Upstream API

Signed-off-by: Casey Callendrello <c1@caseyc.net>
Signed-off-by: Ben Kochie <superq@gmail.com>

* A little more clenaup

* Fix some docs.
* Use the correct plugin register method.
* Cleanup some review items.

Signed-off-by: Ben Kochie <superq@gmail.com>

* Add metrics counter for DNS64 translations

Add a basic counter of how many DNS64 translations have been completed.

Signed-off-by: Ben Kochie <superq@gmail.com>

* Add DNSSEC bug link

Signed-off-by: Ben Kochie <superq@gmail.com>

* Test cleanup

Signed-off-by: Ben Kochie <superq@gmail.com>

* dns64: more test cleanup

Signed-off-by: Casey Callendrello <c1@caseyc.net>

Co-authored-by: Casey Callendrello <c1@caseyc.net>
2020-03-26 08:42:23 +01:00
Zou Nengren
1dba31ee7d
export config file hash in a metric (#3768)
Signed-off-by: zounengren <zounengren@cmss.chinamobile.com>
2020-03-25 14:33:04 +01:00