Nguyen Quang Huy
42cf6606fc
Fix error string should not be capitalized ( #2608 )
...
From [Golang coding convention](https://github.com/golang/go/wiki/CodeReviewComments#error-strings )
Co-Authored-By: Nguyen Van Trung [trungnvfet@outlook.com ](mailto:trungnvfet@outlook.com)
Signed-off-by: Nguyen Quang Huy [huynq0911@gmail.com ](mailto:huynq0911@gmail.com)
2019-02-27 08:25:02 -05:00
Miek Gieben
4f0b36e57e
Extend presubmit to covert test and request ( #1846 )
...
Fix the casing *and* fix use of context as we were still referencing
the non-std lib context - no wondering how this could have worked...
2018-06-01 15:12:49 +01:00
Miek Gieben
be47709270
More Middleware -> Plugin conversions ( #1088 )
...
Forgot about these.
2017-09-16 14:13:28 +01:00
Miek Gieben
d8714e64e4
Remove the word middleware ( #1067 )
...
* Rename middleware to plugin
first pass; mostly used 'sed', few spots where I manually changed
text.
This still builds a coredns binary.
* fmt error
* Rename AddMiddleware to AddPlugin
* Readd AddMiddleware to remain backwards compat
2017-09-14 09:36:06 +01:00
Miek Gieben
bcb2eb1ecc
all: gometalinter ( #843 )
...
* kubernetes/reverse: remove deadcode
* deadcode in errors and kubernetes removed
* unnecessary conversion
* constants
* proxy: time.Since()
* simplications
* static check
* Disable test/external_test
2017-08-06 05:54:24 -07:00
Miek Gieben
ea0a7d0076
test: add external compilation test ( #803 )
...
Pull down example middleware and compile it in (this should compile)
then check if dns.example is included in the list of plugins
(middlewares)
2017-07-29 04:04:12 -07:00
