Commit graph

5 commits

Author SHA1 Message Date
Zou Nengren
8c6d016ad6
ignore vendor when presubmit test (#3999)
Signed-off-by: zounengren <zounengren@cmss.chinamobile.com>
2020-07-21 10:23:52 +02:00
Sylvain Rabot
510f2c503d
presubmit: improve output (#3641)
* presubmit: buffer errors to display them all at once

Signed-off-by: Sylvain Rabot <s.rabot@lectra.com>

* presubmit: make path absolute so they can be clickable in shells

Signed-off-by: Sylvain Rabot <s.rabot@lectra.com>

* presubmit: remove useless return

Signed-off-by: Sylvain Rabot <s.rabot@lectra.com>

* presubmit: fix error message

Signed-off-by: Sylvain Rabot <s.rabot@lectra.com>

* presubmit: annotate Scanner error with concerned file path

Signed-off-by: Sylvain Rabot <s.rabot@lectra.com>
2020-01-30 12:06:58 +00:00
Miek Gieben
995179a6c6
presubmit: check import path ordering (#3636)
Add a test for this as well as it's annoying to point out in every code
review.
Fix all the import paths that are flagged by this new test.

Fixes: #3634

Signed-off-by: Miek Gieben <miek@miek.nl>
2020-01-30 09:19:26 +00:00
Miek Gieben
f66c2bac25
Remove all shell presubmits (#3631)
This ports the shell presubmit to Go and makes them better; esp the
Errorf/Logf/Fatalf one because it actually parses the code and works of
the AST.

These error will now show up in the travis/circle CI runs where they
belong.

Signed-off-by: Miek Gieben <miek@miek.nl>
2020-01-28 19:07:11 +00:00
Miek Gieben
40d0fd8598
presubmit tests (#3630)
* presubmit tests

Rename the test file to presubmit_test.go
Remove println from previous merge.
Add filename hyphen check
Remove the shell presubmit file that did this before

Signed-off-by: Miek Gieben <miek@miek.nl>

* remove

Signed-off-by: Miek Gieben <miek@miek.nl>
2020-01-28 15:47:28 +00:00
Renamed from test/trailing_test.go (Browse further)