0cb0136570
* Add proto and client-ip trace tags Signed-off-by: Adam Malcontenti-Wilson <amalcontenti-wilson@zendesk.com> * Commit my own suggestion Signed-off-by: Miek Gieben <miek@miek.nl> Co-authored-by: Adam Malcontenti-Wilson <amalcontenti-wilson@zendesk.com>
102 lines
3 KiB
Go
102 lines
3 KiB
Go
package trace
|
|
|
|
import (
|
|
"context"
|
|
"testing"
|
|
|
|
"github.com/coredns/caddy"
|
|
"github.com/coredns/coredns/plugin/pkg/dnstest"
|
|
"github.com/coredns/coredns/plugin/pkg/rcode"
|
|
"github.com/coredns/coredns/plugin/test"
|
|
"github.com/coredns/coredns/request"
|
|
|
|
"github.com/miekg/dns"
|
|
"github.com/opentracing/opentracing-go/mocktracer"
|
|
)
|
|
|
|
func TestStartup(t *testing.T) {
|
|
m, err := traceParse(caddy.NewTestController("dns", `trace`))
|
|
if err != nil {
|
|
t.Errorf("Error parsing test input: %s", err)
|
|
return
|
|
}
|
|
if m.Name() != "trace" {
|
|
t.Errorf("Wrong name from GetName: %s", m.Name())
|
|
}
|
|
err = m.OnStartup()
|
|
if err != nil {
|
|
t.Errorf("Error starting tracing plugin: %s", err)
|
|
return
|
|
}
|
|
if m.Tracer() == nil {
|
|
t.Errorf("Error, no tracer created")
|
|
}
|
|
}
|
|
|
|
func TestTrace(t *testing.T) {
|
|
cases := []struct {
|
|
name string
|
|
rcode int
|
|
question *dns.Msg
|
|
server string
|
|
}{
|
|
{
|
|
name: "NXDOMAIN",
|
|
rcode: dns.RcodeNameError,
|
|
question: new(dns.Msg).SetQuestion("example.org.", dns.TypeA),
|
|
},
|
|
{
|
|
name: "NOERROR",
|
|
rcode: dns.RcodeSuccess,
|
|
question: new(dns.Msg).SetQuestion("example.net.", dns.TypeCNAME),
|
|
},
|
|
}
|
|
|
|
for _, tc := range cases {
|
|
t.Run(tc.name, func(t *testing.T) {
|
|
w := dnstest.NewRecorder(&test.ResponseWriter{})
|
|
m := mocktracer.New()
|
|
tr := &trace{
|
|
Next: test.HandlerFunc(func(_ context.Context, w dns.ResponseWriter, r *dns.Msg) (int, error) {
|
|
m := new(dns.Msg)
|
|
m.SetRcode(r, tc.rcode)
|
|
w.WriteMsg(m)
|
|
return tc.rcode, nil
|
|
}),
|
|
every: 1,
|
|
tracer: m,
|
|
}
|
|
ctx := context.TODO()
|
|
if _, err := tr.ServeDNS(ctx, w, tc.question); err != nil {
|
|
t.Fatalf("Error during tr.ServeDNS(ctx, w, %v): %v", tc.question, err)
|
|
}
|
|
|
|
fs := m.FinishedSpans()
|
|
// Each trace consists of two spans; the root and the Next function.
|
|
if len(fs) != 2 {
|
|
t.Fatalf("Unexpected span count: len(fs): want 2, got %v", len(fs))
|
|
}
|
|
|
|
rootSpan := fs[1]
|
|
req := request.Request{W: w, Req: tc.question}
|
|
if rootSpan.OperationName != spanName(ctx, req) {
|
|
t.Errorf("Unexpected span name: rootSpan.Name: want %v, got %v", spanName(ctx, req), rootSpan.OperationName)
|
|
}
|
|
if rootSpan.Tag(tagName) != req.Name() {
|
|
t.Errorf("Unexpected span tag: rootSpan.Tag(%v): want %v, got %v", tagName, req.Name(), rootSpan.Tag(tagName))
|
|
}
|
|
if rootSpan.Tag(tagType) != req.Type() {
|
|
t.Errorf("Unexpected span tag: rootSpan.Tag(%v): want %v, got %v", tagType, req.Type(), rootSpan.Tag(tagType))
|
|
}
|
|
if rootSpan.Tag(tagProto) != req.Proto() {
|
|
t.Errorf("Unexpected span tag: rootSpan.Tag(%v): want %v, got %v", tagProto, req.Proto(), rootSpan.Tag(tagProto))
|
|
}
|
|
if rootSpan.Tag(tagRemote) != req.IP() {
|
|
t.Errorf("Unexpected span tag: rootSpan.Tag(%v): want %v, got %v", tagRemote, req.IP(), rootSpan.Tag(tagRemote))
|
|
}
|
|
if rootSpan.Tag(tagRcode) != rcode.ToString(tc.rcode) {
|
|
t.Errorf("Unexpected span tag: rootSpan.Tag(%v): want %v, got %v", tagRcode, rcode.ToString(tc.rcode), rootSpan.Tag(tagRcode))
|
|
}
|
|
})
|
|
}
|
|
}
|