289f53d386
* Removing unnecessary gitignore pattern
* Updating Makefile to run unittests for subpackages
* Adding Corefile validation to ignore overlapping zones
* Fixing SRV query handling
* Updating README.md now that SRV works
* Fixing debug message, adding code comment
* Clarifying implementation of zone normalization
* "Overlapping zones" is ill-defined. Reimplemented zone overlap/subzone
checking to contain these functions in k8s middleware and provide
better code comments explaining the normalization.
* Separate build verbosity from test verbosity
* Cleaning up comments to match repo code style
* Merging warning messages into single message
* Moving function docs to before function declaration
* Adding test cases for k8sclient connector
* Tests cover connector create and setting base url
* Fixed bugs in connector create and setting base url functions
* Updaing README to group and order development work
* Priority focused on achieving functional parity with SkyDNS.
* Adding work items to README and cleaning up formatting
* More README format cleaning
* List formating
* Refactoring k8s API call to allow dependency injection
* Add test cases for data parsing from k8s into dataobject structures
* URL is dependency-injected to allow replacement with a mock http
server during test execution
* Adding more data validation for JSON parsing tests
* Adding test case for GetResourceList()
* Adding notes about SkyDNS embedded IP and port record names
* Marked test case implemented.
* Fixing formatting for example command.
* Fixing formatting
* Adding notes about Docker image building.
* Adding SkyDNS work item
* Updating TODO list
* Adding name template to Corefile to specify how k8s record names are assembled
* Adding template support for multi-segment zones
* Updating example CoreFile for k8s with template comment
* Misc whitespace cleanup
* Adding SkyDNS naming notes
* Adding namespace filtering to CoreFile config
* Updating example k8sCoreFile to specify namespaces
* Removing unused codepath
* Adding check for valid namespace
* More README TODO restructuring to focus effort
* Adding template validation while parsing CoreFile
* Record name template is considered invalid if it contains a symbol of the form ${bar} where the symbol
"${bar}" is not an accepted template symbol.
* Refactoring generation of answer records
* Parse typeName out of query string
* Refactor answer record creation as operation over list of ServiceItems
* Moving k8s API caching into SkyDNS equivalency segment
* Adding function to assemble record names from template
* Warning: This commit may be broken. Syncing to get laptop code over to dev machine.
* More todo notes
* Adding comment describing sample test data.
* Update k8sCorefile
* Adding comment
* Adding filtering support for kubernetes "type"
* Required refactoring to support reuse of the StringInSlice function.
* Cleaning up formatting
* Adding note about SkyDNS supporting word "any".
* baseUrl -> baseURL
* Also removed debug statement from core/setup/kubernetes.go
* Fixing test breaking from Url -> URL naming changes
* Changing record name template language ${...} -> {...}
* Fix formatting with go fmt
* Updating all k8sclient data getters to return error value
* Adding error message to k8sclient data accessors
* Cleaning up setup for kubernetes
* Removed verbose nils in initial k8s middleware instance
* Set reasonable defaults if CoreFile has no parameters in the
kubernetes block. (k8s endpoint, and name template)
* Formatting cleanup -- go fmt
104 lines
2.5 KiB
Go
104 lines
2.5 KiB
Go
package kubernetes
|
|
|
|
import (
|
|
"fmt"
|
|
|
|
"github.com/miekg/coredns/middleware"
|
|
|
|
"github.com/miekg/dns"
|
|
"golang.org/x/net/context"
|
|
)
|
|
|
|
func (k Kubernetes) ServeDNS(ctx context.Context, w dns.ResponseWriter, r *dns.Msg) (int, error) {
|
|
|
|
fmt.Printf("[debug] here entering ServeDNS: ctx:%v dnsmsg:%v\n", ctx, r)
|
|
|
|
state := middleware.State{W: w, Req: r}
|
|
if state.QClass() != dns.ClassINET {
|
|
return dns.RcodeServerFailure, fmt.Errorf("can only deal with ClassINET")
|
|
}
|
|
|
|
// Check that query matches one of the zones served by this middleware,
|
|
// otherwise delegate to the next in the pipeline.
|
|
zone := middleware.Zones(k.Zones).Matches(state.Name())
|
|
if zone == "" {
|
|
if k.Next == nil {
|
|
return dns.RcodeServerFailure, nil
|
|
}
|
|
return k.Next.ServeDNS(ctx, w, r)
|
|
}
|
|
|
|
m := new(dns.Msg)
|
|
m.SetReply(r)
|
|
m.Authoritative, m.RecursionAvailable, m.Compress = true, true, true
|
|
|
|
var (
|
|
records, extra []dns.RR
|
|
err error
|
|
)
|
|
switch state.Type() {
|
|
case "A":
|
|
records, err = k.A(zone, state, nil)
|
|
case "AAAA":
|
|
records, err = k.AAAA(zone, state, nil)
|
|
case "TXT":
|
|
records, err = k.TXT(zone, state)
|
|
// TODO: change lookup to return appropriate error. Then add code below
|
|
// this switch to check for the error and return not implemented.
|
|
//return dns.RcodeNotImplemented, nil
|
|
case "CNAME":
|
|
records, err = k.CNAME(zone, state)
|
|
case "MX":
|
|
records, extra, err = k.MX(zone, state)
|
|
case "SRV":
|
|
records, extra, err = k.SRV(zone, state)
|
|
case "SOA":
|
|
records = []dns.RR{k.SOA(zone, state)}
|
|
case "NS":
|
|
if state.Name() == zone {
|
|
records, extra, err = k.NS(zone, state)
|
|
break
|
|
}
|
|
fallthrough
|
|
default:
|
|
// Do a fake A lookup, so we can distinguish betwen NODATA and NXDOMAIN
|
|
_, err = k.A(zone, state, nil)
|
|
}
|
|
if isKubernetesNameError(err) {
|
|
return k.Err(zone, dns.RcodeNameError, state)
|
|
}
|
|
if err != nil {
|
|
return dns.RcodeServerFailure, err
|
|
}
|
|
|
|
if len(records) == 0 {
|
|
return k.Err(zone, dns.RcodeSuccess, state)
|
|
}
|
|
|
|
m.Answer = append(m.Answer, records...)
|
|
m.Extra = append(m.Extra, extra...)
|
|
|
|
m = dedup(m)
|
|
state.SizeAndDo(m)
|
|
m, _ = state.Scrub(m)
|
|
w.WriteMsg(m)
|
|
return dns.RcodeSuccess, nil
|
|
}
|
|
|
|
// NoData write a nodata response to the client.
|
|
func (k Kubernetes) Err(zone string, rcode int, state middleware.State) (int, error) {
|
|
m := new(dns.Msg)
|
|
m.SetRcode(state.Req, rcode)
|
|
m.Ns = []dns.RR{k.SOA(zone, state)}
|
|
state.SizeAndDo(m)
|
|
state.W.WriteMsg(m)
|
|
return rcode, nil
|
|
}
|
|
|
|
func dedup(m *dns.Msg) *dns.Msg {
|
|
// TODO(miek): expensive!
|
|
m.Answer = dns.Dedup(m.Answer, nil)
|
|
m.Ns = dns.Dedup(m.Ns, nil)
|
|
m.Extra = dns.Dedup(m.Extra, nil)
|
|
return m
|
|
}
|