* Removing unnecessary gitignore pattern * Updating Makefile to run unittests for subpackages * Adding Corefile validation to ignore overlapping zones * Fixing SRV query handling * Updating README.md now that SRV works * Fixing debug message, adding code comment * Clarifying implementation of zone normalization * "Overlapping zones" is ill-defined. Reimplemented zone overlap/subzone checking to contain these functions in k8s middleware and provide better code comments explaining the normalization. * Separate build verbosity from test verbosity * Cleaning up comments to match repo code style * Merging warning messages into single message * Moving function docs to before function declaration * Adding test cases for k8sclient connector * Tests cover connector create and setting base url * Fixed bugs in connector create and setting base url functions * Updaing README to group and order development work * Priority focused on achieving functional parity with SkyDNS. * Adding work items to README and cleaning up formatting * More README format cleaning * List formating * Refactoring k8s API call to allow dependency injection * Add test cases for data parsing from k8s into dataobject structures * URL is dependency-injected to allow replacement with a mock http server during test execution * Adding more data validation for JSON parsing tests * Adding test case for GetResourceList() * Adding notes about SkyDNS embedded IP and port record names * Marked test case implemented. * Fixing formatting for example command. * Fixing formatting * Adding notes about Docker image building. * Adding SkyDNS work item * Updating TODO list * Adding name template to Corefile to specify how k8s record names are assembled * Adding template support for multi-segment zones * Updating example CoreFile for k8s with template comment * Misc whitespace cleanup * Adding SkyDNS naming notes * Adding namespace filtering to CoreFile config * Updating example k8sCoreFile to specify namespaces * Removing unused codepath * Adding check for valid namespace * More README TODO restructuring to focus effort * Adding template validation while parsing CoreFile * Record name template is considered invalid if it contains a symbol of the form ${bar} where the symbol "${bar}" is not an accepted template symbol. * Refactoring generation of answer records * Parse typeName out of query string * Refactor answer record creation as operation over list of ServiceItems * Moving k8s API caching into SkyDNS equivalency segment * Adding function to assemble record names from template * Warning: This commit may be broken. Syncing to get laptop code over to dev machine. * More todo notes * Adding comment describing sample test data. * Update k8sCorefile * Adding comment * Adding filtering support for kubernetes "type" * Required refactoring to support reuse of the StringInSlice function. * Cleaning up formatting * Adding note about SkyDNS supporting word "any". * baseUrl -> baseURL * Also removed debug statement from core/setup/kubernetes.go * Fixing test breaking from Url -> URL naming changes * Changing record name template language ${...} -> {...} * Fix formatting with go fmt * Updating all k8sclient data getters to return error value * Adding error message to k8sclient data accessors * Cleaning up setup for kubernetes * Removed verbose nils in initial k8s middleware instance * Set reasonable defaults if CoreFile has no parameters in the kubernetes block. (k8s endpoint, and name template) * Formatting cleanup -- go fmt
260 lines
7.3 KiB
Go
260 lines
7.3 KiB
Go
// Package kubernetes provides the kubernetes backend.
|
|
package kubernetes
|
|
|
|
import (
|
|
"errors"
|
|
"fmt"
|
|
"time"
|
|
|
|
"github.com/miekg/coredns/middleware"
|
|
k8sc "github.com/miekg/coredns/middleware/kubernetes/k8sclient"
|
|
"github.com/miekg/coredns/middleware/kubernetes/msg"
|
|
"github.com/miekg/coredns/middleware/kubernetes/nametemplate"
|
|
"github.com/miekg/coredns/middleware/kubernetes/util"
|
|
"github.com/miekg/coredns/middleware/proxy"
|
|
// "github.com/miekg/coredns/middleware/singleflight"
|
|
|
|
"github.com/miekg/dns"
|
|
"golang.org/x/net/context"
|
|
)
|
|
|
|
type Kubernetes struct {
|
|
Next middleware.Handler
|
|
Zones []string
|
|
Proxy proxy.Proxy // Proxy for looking up names during the resolution process
|
|
Ctx context.Context
|
|
// Inflight *singleflight.Group
|
|
APIConn *k8sc.K8sConnector
|
|
NameTemplate *nametemplate.NameTemplate
|
|
Namespaces *[]string
|
|
}
|
|
|
|
// getZoneForName returns the zone string that matches the name and a
|
|
// list of the DNS labels from name that are within the zone.
|
|
// For example, if "coredns.local" is a zone configured for the
|
|
// Kubernetes middleware, then getZoneForName("a.b.coredns.local")
|
|
// will return ("coredns.local", ["a", "b"]).
|
|
func (g Kubernetes) getZoneForName(name string) (string, []string) {
|
|
var zone string
|
|
var serviceSegments []string
|
|
|
|
for _, z := range g.Zones {
|
|
if dns.IsSubDomain(z, name) {
|
|
zone = z
|
|
|
|
serviceSegments = dns.SplitDomainName(name)
|
|
serviceSegments = serviceSegments[:len(serviceSegments)-dns.CountLabel(zone)]
|
|
break
|
|
}
|
|
}
|
|
|
|
return zone, serviceSegments
|
|
}
|
|
|
|
// Records looks up services in kubernetes.
|
|
// If exact is true, it will lookup just
|
|
// this name. This is used when find matches when completing SRV lookups
|
|
// for instance.
|
|
func (g Kubernetes) Records(name string, exact bool) ([]msg.Service, error) {
|
|
var (
|
|
serviceName string
|
|
namespace string
|
|
typeName string
|
|
)
|
|
|
|
fmt.Println("enter Records('", name, "', ", exact, ")")
|
|
zone, serviceSegments := g.getZoneForName(name)
|
|
|
|
/*
|
|
// For initial implementation, assume namespace is first serviceSegment
|
|
// and service name is remaining segments.
|
|
serviceSegLen := len(serviceSegments)
|
|
if serviceSegLen >= 2 {
|
|
namespace = serviceSegments[serviceSegLen-1]
|
|
serviceName = strings.Join(serviceSegments[:serviceSegLen-1], ".")
|
|
}
|
|
// else we are looking up the zone. So handle the NS, SOA records etc.
|
|
*/
|
|
|
|
// TODO: Implementation above globbed together segments for the serviceName if
|
|
// multiple segments remained. Determine how to do similar globbing using
|
|
// the template-based implementation.
|
|
namespace = g.NameTemplate.GetNamespaceFromSegmentArray(serviceSegments)
|
|
serviceName = g.NameTemplate.GetServiceFromSegmentArray(serviceSegments)
|
|
typeName = g.NameTemplate.GetTypeFromSegmentArray(serviceSegments)
|
|
|
|
fmt.Println("[debug] exact: ", exact)
|
|
fmt.Println("[debug] zone: ", zone)
|
|
fmt.Println("[debug] servicename: ", serviceName)
|
|
fmt.Println("[debug] namespace: ", namespace)
|
|
fmt.Println("[debug] typeName: ", typeName)
|
|
fmt.Println("[debug] APIconn: ", g.APIConn)
|
|
|
|
// TODO: Implement wildcard support to allow blank namespace value
|
|
if namespace == "" {
|
|
err := errors.New("Parsing query string did not produce a namespace value")
|
|
fmt.Printf("[ERROR] %v\n", err)
|
|
return nil, err
|
|
}
|
|
|
|
// Abort if the namespace is not published per CoreFile
|
|
if g.Namespaces != nil && !util.StringInSlice(namespace, *g.Namespaces) {
|
|
return nil, nil
|
|
}
|
|
|
|
k8sItems, err := g.APIConn.GetServiceItemsInNamespace(namespace, serviceName)
|
|
fmt.Println("[debug] k8s items:", k8sItems)
|
|
|
|
if err != nil {
|
|
fmt.Printf("[ERROR] Got error while looking up ServiceItems. Error is: %v\n", err)
|
|
return nil, err
|
|
}
|
|
if k8sItems == nil {
|
|
// Did not find item in k8s
|
|
return nil, nil
|
|
}
|
|
|
|
// test := g.NameTemplate.GetRecordNameFromNameValues(nametemplate.NameValues{ServiceName: serviceName, TypeName: typeName, Namespace: namespace, Zone: zone})
|
|
// fmt.Printf("[debug] got recordname %v\n", test)
|
|
|
|
records := g.getRecordsForServiceItems(k8sItems, name)
|
|
|
|
return records, nil
|
|
}
|
|
|
|
// TODO: assemble name from parts found in k8s data based on name template rather than reusing query string
|
|
func (g Kubernetes) getRecordsForServiceItems(serviceItems []*k8sc.ServiceItem, name string) []msg.Service {
|
|
var records []msg.Service
|
|
|
|
for _, item := range serviceItems {
|
|
fmt.Println("[debug] clusterIP:", item.Spec.ClusterIP)
|
|
for _, p := range item.Spec.Ports {
|
|
fmt.Println("[debug] port:", p.Port)
|
|
}
|
|
|
|
clusterIP := item.Spec.ClusterIP
|
|
|
|
s := msg.Service{Host: name}
|
|
records = append(records, s)
|
|
for _, p := range item.Spec.Ports {
|
|
s := msg.Service{Host: clusterIP, Port: p.Port}
|
|
records = append(records, s)
|
|
}
|
|
}
|
|
|
|
fmt.Printf("[debug] records from getRecordsForServiceItems(): %v\n", records)
|
|
return records
|
|
}
|
|
|
|
/*
|
|
// Get performs the call to the Kubernetes http API.
|
|
func (g Kubernetes) Get(path string, recursive bool) (bool, error) {
|
|
|
|
fmt.Println("[debug] in Get path: ", path)
|
|
fmt.Println("[debug] in Get recursive: ", recursive)
|
|
|
|
return false, nil
|
|
}
|
|
*/
|
|
|
|
func (g Kubernetes) splitDNSName(name string) []string {
|
|
l := dns.SplitDomainName(name)
|
|
|
|
for i, j := 0, len(l)-1; i < j; i, j = i+1, j-1 {
|
|
l[i], l[j] = l[j], l[i]
|
|
}
|
|
|
|
return l
|
|
}
|
|
|
|
// skydns/local/skydns/east/staging/web
|
|
// skydns/local/skydns/west/production/web
|
|
//
|
|
// skydns/local/skydns/*/*/web
|
|
// skydns/local/skydns/*/web
|
|
|
|
// loopNodes recursively loops through the nodes and returns all the values. The nodes' keyname
|
|
// will be match against any wildcards when star is true.
|
|
/*
|
|
func (g Kubernetes) loopNodes(ns []*etcdc.Node, nameParts []string, star bool, bx map[msg.Service]bool) (sx []msg.Service, err error) {
|
|
if bx == nil {
|
|
bx = make(map[msg.Service]bool)
|
|
}
|
|
Nodes:
|
|
for _, n := range ns {
|
|
if n.Dir {
|
|
nodes, err := g.loopNodes(n.Nodes, nameParts, star, bx)
|
|
if err != nil {
|
|
return nil, err
|
|
}
|
|
sx = append(sx, nodes...)
|
|
continue
|
|
}
|
|
if star {
|
|
keyParts := strings.Split(n.Key, "/")
|
|
for i, n := range nameParts {
|
|
if i > len(keyParts)-1 {
|
|
// name is longer than key
|
|
continue Nodes
|
|
}
|
|
if n == "*" || n == "any" {
|
|
continue
|
|
}
|
|
if keyParts[i] != n {
|
|
continue Nodes
|
|
}
|
|
}
|
|
}
|
|
serv := new(msg.Service)
|
|
if err := json.Unmarshal([]byte(n.Value), serv); err != nil {
|
|
return nil, err
|
|
}
|
|
b := msg.Service{Host: serv.Host, Port: serv.Port, Priority: serv.Priority, Weight: serv.Weight, Text: serv.Text, Key: n.Key}
|
|
if _, ok := bx[b]; ok {
|
|
continue
|
|
}
|
|
bx[b] = true
|
|
|
|
serv.Key = n.Key
|
|
serv.Ttl = g.Ttl(n, serv)
|
|
if serv.Priority == 0 {
|
|
serv.Priority = priority
|
|
}
|
|
sx = append(sx, *serv)
|
|
}
|
|
return sx, nil
|
|
}
|
|
|
|
// Ttl returns the smaller of the kubernetes TTL and the service's
|
|
// TTL. If neither of these are set (have a zero value), a default is used.
|
|
func (g Kubernetes) Ttl(node *etcdc.Node, serv *msg.Service) uint32 {
|
|
kubernetesTtl := uint32(node.TTL)
|
|
|
|
if kubernetesTtl == 0 && serv.Ttl == 0 {
|
|
return ttl
|
|
}
|
|
if kubernetesTtl == 0 {
|
|
return serv.Ttl
|
|
}
|
|
if serv.Ttl == 0 {
|
|
return kubernetesTtl
|
|
}
|
|
if kubernetesTtl < serv.Ttl {
|
|
return kubernetesTtl
|
|
}
|
|
return serv.Ttl
|
|
}
|
|
*/
|
|
|
|
// kubernetesNameError checks if the error is ErrorCodeKeyNotFound from kubernetes.
|
|
func isKubernetesNameError(err error) bool {
|
|
return false
|
|
}
|
|
|
|
const (
|
|
priority = 10 // default priority when nothing is set
|
|
ttl = 300 // default ttl when nothing is set
|
|
minTtl = 60
|
|
hostmaster = "hostmaster"
|
|
k8sTimeout = 5 * time.Second
|
|
)
|