TrueCloudLab/coredns
16
0
Fork 2
Code Issues Pull requests 3 Projects Releases Packages Wiki Activity Actions
coredns/plugin
History
Miek Gieben 35b40a84f2
plugin/cache: Fix filtering (#4148) 
The filtering of DNSSEC records in the cache plugin was not done
correctly. Also the change to introduced this bug didn't take into
account that the cache - by virtue of differentiating between DNSSEC and
no-DNSSEC - relied on not copying the data from the cache.

This change copies and then filters the data and factors the filtering
into a function that is used in two places (albeit with on ugly boolean
parameters to prevent copying things twice).

Add tests, do_test.go is moved to test/cache_test.go because the OPT
handing is done outside of the cache plugin. The core server re-attaches
the correct OPT when replying, so that makes for a better e2e test.

Added small unit test for filterRRslice and an explicit test that asks
for DNSSEC first and then plain, and vice versa to test cache behavior.

Fixes: #4146

Signed-off-by: Miek Gieben <miek@miek.nl>
2020-09-28 07:53:00 -07:00
..
acl For caddy v1 in our org (#4018) 2020-09-24 18:14:41 +02:00
any For caddy v1 in our org (#4018) 2020-09-24 18:14:41 +02:00
auto Cherry-pick: Implement notifies for transfer plugin (#3972) (#4142) 2020-09-24 20:30:39 +02:00
autopath For caddy v1 in our org (#4018) 2020-09-24 18:14:41 +02:00
azure For caddy v1 in our org (#4018) 2020-09-24 18:14:41 +02:00
bind For caddy v1 in our org (#4018) 2020-09-24 18:14:41 +02:00
bufsize For caddy v1 in our org (#4018) 2020-09-24 18:14:41 +02:00
cache plugin/cache: Fix filtering (#4148) 2020-09-28 07:53:00 -07:00
cancel For caddy v1 in our org (#4018) 2020-09-24 18:14:41 +02:00
chaos For caddy v1 in our org (#4018) 2020-09-24 18:14:41 +02:00
clouddns For caddy v1 in our org (#4018) 2020-09-24 18:14:41 +02:00
debug For caddy v1 in our org (#4018) 2020-09-24 18:14:41 +02:00
deprecated For caddy v1 in our org (#4018) 2020-09-24 18:14:41 +02:00
dns64 For caddy v1 in our org (#4018) 2020-09-24 18:14:41 +02:00
dnssec For caddy v1 in our org (#4018) 2020-09-24 18:14:41 +02:00
dnstap For caddy v1 in our org (#4018) 2020-09-24 18:14:41 +02:00
erratic For caddy v1 in our org (#4018) 2020-09-24 18:14:41 +02:00
errors For caddy v1 in our org (#4018) 2020-09-24 18:14:41 +02:00
etcd Cherry-pick: Implement notifies for transfer plugin (#3972) (#4142) 2020-09-24 20:30:39 +02:00
file Cherry-pick: Implement notifies for transfer plugin (#3972) (#4142) 2020-09-24 20:30:39 +02:00
forward For caddy v1 in our org (#4018) 2020-09-24 18:14:41 +02:00
grpc For caddy v1 in our org (#4018) 2020-09-24 18:14:41 +02:00
health For caddy v1 in our org (#4018) 2020-09-24 18:14:41 +02:00
hosts For caddy v1 in our org (#4018) 2020-09-24 18:14:41 +02:00
import Directive -> plugin (#3363) 2019-10-08 10:20:48 +01:00
k8s_external For caddy v1 in our org (#4018) 2020-09-24 18:14:41 +02:00
kubernetes Cherry-pick: Implement notifies for transfer plugin (#3972) (#4142) 2020-09-24 20:30:39 +02:00
loadbalance For caddy v1 in our org (#4018) 2020-09-24 18:14:41 +02:00
log For caddy v1 in our org (#4018) 2020-09-24 18:14:41 +02:00
loop For caddy v1 in our org (#4018) 2020-09-24 18:14:41 +02:00
metadata For caddy v1 in our org (#4018) 2020-09-24 18:14:41 +02:00
metrics For caddy v1 in our org (#4018) 2020-09-24 18:14:41 +02:00
nsid For caddy v1 in our org (#4018) 2020-09-24 18:14:41 +02:00
pkg Cherry-pick: Implement notifies for transfer plugin (#3972) (#4142) 2020-09-24 20:30:39 +02:00
pprof For caddy v1 in our org (#4018) 2020-09-24 18:14:41 +02:00
ready For caddy v1 in our org (#4018) 2020-09-24 18:14:41 +02:00
reload For caddy v1 in our org (#4018) 2020-09-24 18:14:41 +02:00
rewrite For caddy v1 in our org (#4018) 2020-09-24 18:14:41 +02:00
root For caddy v1 in our org (#4018) 2020-09-24 18:14:41 +02:00
route53 For caddy v1 in our org (#4018) 2020-09-24 18:14:41 +02:00
secondary Cherry-pick: Implement notifies for transfer plugin (#3972) (#4142) 2020-09-24 20:30:39 +02:00
sign For caddy v1 in our org (#4018) 2020-09-24 18:14:41 +02:00
template For caddy v1 in our org (#4018) 2020-09-24 18:14:41 +02:00
test goreport card fixes (#4139) 2020-09-22 09:22:00 +02:00
tls For caddy v1 in our org (#4018) 2020-09-24 18:14:41 +02:00
trace For caddy v1 in our org (#4018) 2020-09-24 18:14:41 +02:00
transfer Cherry-pick: Implement notifies for transfer plugin (#3972) (#4142) 2020-09-24 20:30:39 +02:00
whoami For caddy v1 in our org (#4018) 2020-09-24 18:14:41 +02:00
backend.go Cherry-pick: Implement notifies for transfer plugin (#3972) (#4142) 2020-09-24 20:30:39 +02:00
backend_lookup.go backend: fix root zone usage (#4039) 2020-07-31 10:58:09 +02:00
done.go go report card fixes (#3182) 2019-08-24 18:14:25 +00:00
log_test.go Clean up tests logging (#1979) 2018-07-19 16:23:06 +01:00
normalize.go add MustNormalize (#3385) 2019-10-19 08:08:14 +01:00
normalize_test.go add MustNormalize (#3385) 2019-10-19 08:08:14 +01:00
plugin.go typo fixes (#3169) 2019-08-21 16:08:55 -04:00
register.go For caddy v1 in our org (#4018) 2020-09-24 18:14:41 +02:00