3e5fd21e68
* file: close correctlty after AXFR Don't hijack, but wait for the writes to be done and then savely close the connection. Fixes: #2929 Signed-off-by: Miek Gieben <miek@miek.nl> * Update comment Signed-off-by: Miek Gieben <miek@miek.nl> * file: close correctlty after AXFR (#2943) apply Signed-off-by: Miek Gieben <miek@miek.nl>
66 lines
1.6 KiB
Go
66 lines
1.6 KiB
Go
package file
|
|
|
|
import (
|
|
"context"
|
|
"fmt"
|
|
"sync"
|
|
|
|
"github.com/coredns/coredns/plugin"
|
|
"github.com/coredns/coredns/request"
|
|
|
|
"github.com/miekg/dns"
|
|
)
|
|
|
|
// Xfr serves up an AXFR.
|
|
type Xfr struct {
|
|
*Zone
|
|
}
|
|
|
|
// ServeDNS implements the plugin.Handler interface.
|
|
func (x Xfr) ServeDNS(ctx context.Context, w dns.ResponseWriter, r *dns.Msg) (int, error) {
|
|
state := request.Request{W: w, Req: r}
|
|
if !x.TransferAllowed(state) {
|
|
return dns.RcodeServerFailure, nil
|
|
}
|
|
if state.QType() != dns.TypeAXFR && state.QType() != dns.TypeIXFR {
|
|
return 0, plugin.Error(x.Name(), fmt.Errorf("xfr called with non transfer type: %d", state.QType()))
|
|
}
|
|
|
|
records := x.All()
|
|
if len(records) == 0 {
|
|
return dns.RcodeServerFailure, nil
|
|
}
|
|
|
|
ch := make(chan *dns.Envelope)
|
|
tr := new(dns.Transfer)
|
|
wg := new(sync.WaitGroup)
|
|
go func() {
|
|
wg.Add(1)
|
|
tr.Out(w, r, ch)
|
|
wg.Done()
|
|
}()
|
|
|
|
j, l := 0, 0
|
|
records = append(records, records[0]) // add closing SOA to the end
|
|
log.Infof("Outgoing transfer of %d records of zone %s to %s started", len(records), x.origin, state.IP())
|
|
for i, r := range records {
|
|
l += dns.Len(r)
|
|
if l > transferLength {
|
|
ch <- &dns.Envelope{RR: records[j:i]}
|
|
l = 0
|
|
j = i
|
|
}
|
|
}
|
|
if j < len(records) {
|
|
ch <- &dns.Envelope{RR: records[j:]}
|
|
}
|
|
close(ch) // Even though we close the channel here, we still have
|
|
wg.Wait() // to wait before we can return and close the connection.
|
|
|
|
return dns.RcodeSuccess, nil
|
|
}
|
|
|
|
// Name implements the plugin.Handler interface.
|
|
func (x Xfr) Name() string { return "xfr" }
|
|
|
|
const transferLength = 1000 // Start a new envelop after message reaches this size in bytes. Intentionally small to test multi envelope parsing.
|