22c0b30d5f
Uppercase all these test errors as well. And extend the presubmit to check for these in the future. Also do a slightly smarter grep to only get t.<something>. as (because dump regexp) this also grep over non test files.
19 lines
629 B
Bash
Executable file
19 lines
629 B
Bash
Executable file
#!/bin/bash
|
|
|
|
echo "** presubmit/$(basename $0)"
|
|
|
|
# Get the tests that call t.* without capitalizing the first char - seems we standardized on that.
|
|
if egrep -r '\bt\.Fatal.?\("[a-z]' "$@"; then
|
|
echo "** presubmit/$(basename $0): please start with an upper case letter when using t.Fatal*()"
|
|
exit 1
|
|
fi
|
|
|
|
if egrep -r '\bt\.Error.?\("[a-z]' "$@"; then
|
|
echo "** presubmit/$(basename $0): please start with an upper case letter when using t.Error*()"
|
|
exit 1
|
|
fi
|
|
|
|
if egrep -r '\bt\.Log.?\("[a-z]' "$@"; then
|
|
echo "** presubmit/$(basename $0): please start with an upper case letter when using t.Log*()"
|
|
exit 1
|
|
fi
|