818d2b10ad
* cidr everywhere: check all middleware Add tests for cidr in only that middleware that already tests for this. Check the other ones manually (and put reverse in the tests cases anyway). Make etcd setup_test run without +build etcd tag - it is not needed for this test - move rest of the code to lookup_test.go. Cleanup proxy test a bit and remove TempDir as there is test.TempFile that does the same thing. Fixes #909 * coredns package * Fix test compile
76 lines
2.4 KiB
Go
76 lines
2.4 KiB
Go
package autopath
|
|
|
|
import (
|
|
"os"
|
|
"reflect"
|
|
"strings"
|
|
"testing"
|
|
|
|
"github.com/coredns/coredns/middleware/test"
|
|
|
|
"github.com/mholt/caddy"
|
|
)
|
|
|
|
func TestSetupAutoPath(t *testing.T) {
|
|
resolv, rm, err := test.TempFile(os.TempDir(), resolvConf)
|
|
if err != nil {
|
|
t.Fatalf("Could not create resolv.conf test file %s: %s", resolvConf, err)
|
|
}
|
|
defer rm()
|
|
|
|
tests := []struct {
|
|
input string
|
|
shouldErr bool
|
|
expectedZone string
|
|
expectedMw string // expected middleware.
|
|
expectedSearch []string // expected search path
|
|
expectedErrContent string // substring from the expected error. Empty for positive cases.
|
|
}{
|
|
// positive
|
|
{`autopath @kubernetes`, false, "", "kubernetes", nil, ""},
|
|
{`autopath example.org @kubernetes`, false, "example.org.", "kubernetes", nil, ""},
|
|
{`autopath 10.0.0.0/8 @kubernetes`, false, "10.in-addr.arpa.", "kubernetes", nil, ""},
|
|
{`autopath ` + resolv, false, "", "", []string{"bar.com.", "baz.com.", ""}, ""},
|
|
// negative
|
|
{`autopath kubernetes`, true, "", "", nil, "open kubernetes: no such file or directory"},
|
|
}
|
|
|
|
for i, test := range tests {
|
|
c := caddy.NewTestController("dns", test.input)
|
|
ap, mw, err := autoPathParse(c)
|
|
|
|
if test.shouldErr && err == nil {
|
|
t.Errorf("Test %d: Expected error but found %s for input %s", i, err, test.input)
|
|
}
|
|
|
|
if err != nil {
|
|
if !test.shouldErr {
|
|
t.Errorf("Test %d: Expected no error but found one for input %s. Error was: %v", i, test.input, err)
|
|
}
|
|
|
|
if !strings.Contains(err.Error(), test.expectedErrContent) {
|
|
t.Errorf("Test %d: Expected error to contain: %v, found error: %v, input: %s", i, test.expectedErrContent, err, test.input)
|
|
}
|
|
}
|
|
|
|
if !test.shouldErr && mw != test.expectedMw {
|
|
t.Errorf("Test %d, Middleware not correctly set for input %s. Expected: %s, actual: %s", i, test.input, test.expectedMw, mw)
|
|
}
|
|
if !test.shouldErr && ap.search != nil {
|
|
if !reflect.DeepEqual(test.expectedSearch, ap.search) {
|
|
t.Errorf("Test %d, wrong searchpath for input %s. Expected: '%v', actual: '%v'", i, test.input, test.expectedSearch, ap.search)
|
|
}
|
|
}
|
|
if !test.shouldErr && test.expectedZone != "" {
|
|
if test.expectedZone != ap.Zones[0] {
|
|
t.Errorf("Test %d, expected zone %q for input %s, got: %q", i, test.expectedZone, test.input, ap.Zones[0])
|
|
}
|
|
}
|
|
}
|
|
}
|
|
|
|
const resolvConf = `nameserver 1.2.3.4
|
|
domain foo.com
|
|
search bar.com baz.com
|
|
options ndots:5
|
|
`
|