0baab055df
This fix tries to address the issue raised in 1275 to clarify the syntax for multiple endpoints specification. This fix also adds additional test cases to demo the usage. This fix fixes 1275. Signed-off-by: Yong Tang <yong.tang.github@outlook.com>
77 lines
2.1 KiB
Go
77 lines
2.1 KiB
Go
package etcd
|
|
|
|
import (
|
|
"strings"
|
|
"testing"
|
|
|
|
"github.com/mholt/caddy"
|
|
)
|
|
|
|
func TestSetupEtcd(t *testing.T) {
|
|
tests := []struct {
|
|
input string
|
|
shouldErr bool
|
|
expectedPath string
|
|
expectedEndpoint []string
|
|
expectedErrContent string // substring from the expected error. Empty for positive cases.
|
|
}{
|
|
// positive
|
|
{
|
|
`etcd`, false, "skydns", []string{"http://localhost:2379"}, "",
|
|
},
|
|
{
|
|
`etcd {
|
|
endpoint http://localhost:2379 http://localhost:3379 http://localhost:4379
|
|
|
|
}`, false, "skydns", []string{"http://localhost:2379", "http://localhost:3379", "http://localhost:4379"}, "",
|
|
},
|
|
{
|
|
`etcd skydns.local {
|
|
endpoint localhost:300
|
|
}
|
|
`, false, "skydns", []string{"localhost:300"}, "",
|
|
},
|
|
// negative
|
|
{
|
|
`etcd {
|
|
endpoints localhost:300
|
|
}
|
|
`, true, "", []string{""}, "unknown property 'endpoints'",
|
|
},
|
|
}
|
|
|
|
for i, test := range tests {
|
|
c := caddy.NewTestController("dns", test.input)
|
|
etcd, _ /*stubzones*/, err := etcdParse(c)
|
|
|
|
if test.shouldErr && err == nil {
|
|
t.Errorf("Test %d: Expected error but found %s for input %s", i, err, test.input)
|
|
}
|
|
|
|
if err != nil {
|
|
if !test.shouldErr {
|
|
t.Errorf("Test %d: Expected no error but found one for input %s. Error was: %v", i, test.input, err)
|
|
continue
|
|
}
|
|
|
|
if !strings.Contains(err.Error(), test.expectedErrContent) {
|
|
t.Errorf("Test %d: Expected error to contain: %v, found error: %v, input: %s", i, test.expectedErrContent, err, test.input)
|
|
continue
|
|
}
|
|
}
|
|
|
|
if !test.shouldErr && etcd.PathPrefix != test.expectedPath {
|
|
t.Errorf("Etcd not correctly set for input %s. Expected: %s, actual: %s", test.input, test.expectedPath, etcd.PathPrefix)
|
|
}
|
|
if !test.shouldErr {
|
|
if len(etcd.endpoints) != len(test.expectedEndpoint) {
|
|
t.Errorf("Etcd not correctly set for input %s. Expected: '%+v', actual: '%+v'", test.input, test.expectedEndpoint, etcd.endpoints)
|
|
}
|
|
for i, endpoint := range etcd.endpoints {
|
|
if endpoint != test.expectedEndpoint[i] {
|
|
t.Errorf("Etcd not correctly set for input %s. Expected: '%+v', actual: '%+v'", test.input, test.expectedEndpoint, etcd.endpoints)
|
|
}
|
|
}
|
|
}
|
|
}
|
|
}
|