* Implement notifies for transfer plugin (#3972) * Fix notifies in transfer plugin Signed-off-by: Miek Gieben <miek@miek.nl> * Make it compile Signed-off-by: Miek Gieben <miek@miek.nl> * Port more plugins Signed-off-by: Miek Gieben <miek@miek.nl> * golint Signed-off-by: Miek Gieben <miek@miek.nl> * Fix tests Signed-off-by: Miek Gieben <miek@miek.nl> * Fix notifies in transfer plugin Signed-off-by: Miek Gieben <miek@miek.nl> * Make it compile Signed-off-by: Miek Gieben <miek@miek.nl> * Port more plugins Signed-off-by: Miek Gieben <miek@miek.nl> * golint Signed-off-by: Miek Gieben <miek@miek.nl> * Fix tests Signed-off-by: Miek Gieben <miek@miek.nl> * Fix tests Signed-off-by: Miek Gieben <miek@miek.nl> * really fix test Signed-off-by: Miek Gieben <miek@miek.nl> * Implement ixfr fallback and unify file and auto for transfering Signed-off-by: Miek Gieben <miek@miek.nl> * Add transfer tests copied and modified from #3452 Signed-off-by: Miek Gieben <miek@miek.nl> * Test correct selection of plugin Signed-off-by: Miek Gieben <miek@miek.nl> * add upstream back in Signed-off-by: Miek Gieben <miek@miek.nl> * Implement ixfr fallback and unify file and auto for transfering Signed-off-by: Miek Gieben <miek@miek.nl> * fix test Signed-off-by: Miek Gieben <miek@miek.nl> * properly merge Signed-off-by: Miek Gieben <miek@miek.nl> * Remove plugin/kubernetes/setup_transfer_test.go Signed-off-by: Yong Tang <yong.tang.github@outlook.com> Co-authored-by: Miek Gieben <miek@miek.nl>
152 lines
3.7 KiB
Go
152 lines
3.7 KiB
Go
// Package file implements a file backend.
|
|
package file
|
|
|
|
import (
|
|
"context"
|
|
"fmt"
|
|
"io"
|
|
|
|
"github.com/coredns/coredns/plugin"
|
|
clog "github.com/coredns/coredns/plugin/pkg/log"
|
|
"github.com/coredns/coredns/plugin/transfer"
|
|
"github.com/coredns/coredns/request"
|
|
|
|
"github.com/miekg/dns"
|
|
)
|
|
|
|
var log = clog.NewWithPlugin("file")
|
|
|
|
type (
|
|
// File is the plugin that reads zone data from disk.
|
|
File struct {
|
|
Next plugin.Handler
|
|
Zones
|
|
transfer *transfer.Transfer
|
|
}
|
|
|
|
// Zones maps zone names to a *Zone.
|
|
Zones struct {
|
|
Z map[string]*Zone // A map mapping zone (origin) to the Zone's data
|
|
Names []string // All the keys from the map Z as a string slice.
|
|
}
|
|
)
|
|
|
|
// ServeDNS implements the plugin.Handle interface.
|
|
func (f File) ServeDNS(ctx context.Context, w dns.ResponseWriter, r *dns.Msg) (int, error) {
|
|
state := request.Request{W: w, Req: r}
|
|
|
|
qname := state.Name()
|
|
// TODO(miek): match the qname better in the map
|
|
zone := plugin.Zones(f.Zones.Names).Matches(qname)
|
|
if zone == "" {
|
|
return plugin.NextOrFailure(f.Name(), f.Next, ctx, w, r)
|
|
}
|
|
|
|
z, ok := f.Zones.Z[zone]
|
|
if !ok || z == nil {
|
|
return dns.RcodeServerFailure, nil
|
|
}
|
|
|
|
// This is only for when we are a secondary zones.
|
|
if r.Opcode == dns.OpcodeNotify {
|
|
if z.isNotify(state) {
|
|
m := new(dns.Msg)
|
|
m.SetReply(r)
|
|
m.Authoritative = true
|
|
w.WriteMsg(m)
|
|
|
|
log.Infof("Notify from %s for %s: checking transfer", state.IP(), zone)
|
|
ok, err := z.shouldTransfer()
|
|
if ok {
|
|
z.TransferIn()
|
|
} else {
|
|
log.Infof("Notify from %s for %s: no SOA serial increase seen", state.IP(), zone)
|
|
}
|
|
if err != nil {
|
|
log.Warningf("Notify from %s for %s: failed primary check: %s", state.IP(), zone, err)
|
|
}
|
|
return dns.RcodeSuccess, nil
|
|
}
|
|
log.Infof("Dropping notify from %s for %s", state.IP(), zone)
|
|
return dns.RcodeSuccess, nil
|
|
}
|
|
|
|
z.RLock()
|
|
exp := z.Expired
|
|
z.RUnlock()
|
|
if exp {
|
|
log.Errorf("Zone %s is expired", zone)
|
|
return dns.RcodeServerFailure, nil
|
|
}
|
|
|
|
answer, ns, extra, result := z.Lookup(ctx, state, qname)
|
|
|
|
m := new(dns.Msg)
|
|
m.SetReply(r)
|
|
m.Authoritative = true
|
|
m.Answer, m.Ns, m.Extra = answer, ns, extra
|
|
|
|
switch result {
|
|
case Success:
|
|
case NoData:
|
|
case NameError:
|
|
m.Rcode = dns.RcodeNameError
|
|
case Delegation:
|
|
m.Authoritative = false
|
|
case ServerFailure:
|
|
return dns.RcodeServerFailure, nil
|
|
}
|
|
|
|
w.WriteMsg(m)
|
|
return dns.RcodeSuccess, nil
|
|
}
|
|
|
|
// Name implements the Handler interface.
|
|
func (f File) Name() string { return "file" }
|
|
|
|
type serialErr struct {
|
|
err string
|
|
zone string
|
|
origin string
|
|
serial int64
|
|
}
|
|
|
|
func (s *serialErr) Error() string {
|
|
return fmt.Sprintf("%s for origin %s in file %s, with %d SOA serial", s.err, s.origin, s.zone, s.serial)
|
|
}
|
|
|
|
// Parse parses the zone in filename and returns a new Zone or an error.
|
|
// If serial >= 0 it will reload the zone, if the SOA hasn't changed
|
|
// it returns an error indicating nothing was read.
|
|
func Parse(f io.Reader, origin, fileName string, serial int64) (*Zone, error) {
|
|
zp := dns.NewZoneParser(f, dns.Fqdn(origin), fileName)
|
|
zp.SetIncludeAllowed(true)
|
|
z := NewZone(origin, fileName)
|
|
seenSOA := false
|
|
for rr, ok := zp.Next(); ok; rr, ok = zp.Next() {
|
|
if err := zp.Err(); err != nil {
|
|
return nil, err
|
|
}
|
|
|
|
if !seenSOA {
|
|
if s, ok := rr.(*dns.SOA); ok {
|
|
seenSOA = true
|
|
|
|
// -1 is valid serial is we failed to load the file on startup.
|
|
|
|
if serial >= 0 && s.Serial == uint32(serial) { // same serial
|
|
return nil, &serialErr{err: "no change in SOA serial", origin: origin, zone: fileName, serial: serial}
|
|
}
|
|
}
|
|
}
|
|
|
|
if err := z.Insert(rr); err != nil {
|
|
return nil, err
|
|
}
|
|
}
|
|
if !seenSOA {
|
|
return nil, fmt.Errorf("file %q has no SOA record for origin %s", fileName, origin)
|
|
}
|
|
|
|
return z, nil
|
|
}
|