coredns/plugin/template/setup.go
Miek Gieben 9c16ed1d14
Default to upstream to self (#2436)
* Default to upstream to self

This is a backwards incompatible change.

This is a massive (cleanup) PR where we default to resolving external
names by the coredns process itself, instead of directly forwarding them
to some upstream.

This ignores any arguments `upstream` may have had and makes it depend
on proxy/forward configuration in the Corefile. This allows resolved
upstream names to be cached and we have better healthchecking of the
upstreams. It also means there is only one way to resolve names, by
either using the proxy or forward plugin.

The proxy/forward lookup.go functions have been removed. This also
lessen the dependency on proxy, meaning deprecating proxy will become
easier. Some tests have been removed as well, or moved to the top-level
test directory as they now require a full coredns process instead of
just the plugin.

For the etcd plugin, the entire StubZone resolving is *dropped*! This
was a hacky (but working) solution to say the least. If someone cares
deeply it can be brought back (maybe)?

The pkg/upstream is now very small and almost does nothing. Also the
New() function was changed to return a pointer to upstream.Upstream. It
also returns only one parameter, so any stragglers using it will
encounter a compile error.

All documentation has been adapted. This affected the following plugins:
* etcd
* file
* auto
* secondary
* federation
* template
* route53

A followup PR will make any upstream directives with arguments an error,
right now they are ignored.

Signed-off-by: Miek Gieben <miek@miek.nl>

* Fix etcd build - probably still fails unit test

Signed-off-by: Miek Gieben <miek@miek.nl>

* Slightly smarter lookup check in upstream

Signed-off-by: Miek Gieben <miek@miek.nl>

* Compilez

Signed-off-by: Miek Gieben <miek@miek.nl>
2019-01-13 16:54:49 +00:00

166 lines
3.8 KiB
Go

package template
import (
"regexp"
gotmpl "text/template"
"github.com/coredns/coredns/core/dnsserver"
"github.com/coredns/coredns/plugin"
"github.com/coredns/coredns/plugin/pkg/upstream"
"github.com/mholt/caddy"
"github.com/miekg/dns"
)
func init() {
caddy.RegisterPlugin("template", caddy.Plugin{
ServerType: "dns",
Action: setupTemplate,
})
}
func setupTemplate(c *caddy.Controller) error {
handler, err := templateParse(c)
if err != nil {
return plugin.Error("template", err)
}
if err := setupMetrics(c); err != nil {
return plugin.Error("template", err)
}
dnsserver.GetConfig(c).AddPlugin(func(next plugin.Handler) plugin.Handler {
handler.Next = next
return handler
})
return nil
}
func templateParse(c *caddy.Controller) (handler Handler, err error) {
handler.Templates = make([]template, 0)
for c.Next() {
if !c.NextArg() {
return handler, c.ArgErr()
}
class, ok := dns.StringToClass[c.Val()]
if !ok {
return handler, c.Errf("invalid query class %s", c.Val())
}
if !c.NextArg() {
return handler, c.ArgErr()
}
qtype, ok := dns.StringToType[c.Val()]
if !ok {
return handler, c.Errf("invalid RR class %s", c.Val())
}
zones := c.RemainingArgs()
if len(zones) == 0 {
zones = make([]string, len(c.ServerBlockKeys))
copy(zones, c.ServerBlockKeys)
}
for i, str := range zones {
zones[i] = plugin.Host(str).Normalize()
}
handler.Zones = append(handler.Zones, zones...)
t := template{qclass: class, qtype: qtype, zones: zones}
t.regex = make([]*regexp.Regexp, 0)
templatePrefix := ""
t.answer = make([]*gotmpl.Template, 0)
for c.NextBlock() {
switch c.Val() {
case "match":
args := c.RemainingArgs()
if len(args) == 0 {
return handler, c.ArgErr()
}
for _, regex := range args {
r, err := regexp.Compile(regex)
if err != nil {
return handler, c.Errf("could not parse regex: %s, %v", regex, err)
}
templatePrefix = templatePrefix + regex + " "
t.regex = append(t.regex, r)
}
case "answer":
args := c.RemainingArgs()
if len(args) == 0 {
return handler, c.ArgErr()
}
for _, answer := range args {
tmpl, err := gotmpl.New("answer").Parse(answer)
if err != nil {
return handler, c.Errf("could not compile template: %s, %v", c.Val(), err)
}
t.answer = append(t.answer, tmpl)
}
case "additional":
args := c.RemainingArgs()
if len(args) == 0 {
return handler, c.ArgErr()
}
for _, additional := range args {
tmpl, err := gotmpl.New("additional").Parse(additional)
if err != nil {
return handler, c.Errf("could not compile template: %s, %v\n", c.Val(), err)
}
t.additional = append(t.additional, tmpl)
}
case "authority":
args := c.RemainingArgs()
if len(args) == 0 {
return handler, c.ArgErr()
}
for _, authority := range args {
tmpl, err := gotmpl.New("authority").Parse(authority)
if err != nil {
return handler, c.Errf("could not compile template: %s, %v\n", c.Val(), err)
}
t.authority = append(t.authority, tmpl)
}
case "rcode":
if !c.NextArg() {
return handler, c.ArgErr()
}
rcode, ok := dns.StringToRcode[c.Val()]
if !ok {
return handler, c.Errf("unknown rcode %s", c.Val())
}
t.rcode = rcode
case "fallthrough":
t.fall.SetZonesFromArgs(c.RemainingArgs())
case "upstream":
c.RemainingArgs() // eat remaining args
t.upstream = upstream.New()
default:
return handler, c.ArgErr()
}
}
if len(t.regex) == 0 {
t.regex = append(t.regex, regexp.MustCompile(".*"))
}
if len(t.answer) == 0 && len(t.authority) == 0 && t.rcode == dns.RcodeSuccess {
return handler, c.Errf("no answer section for template found: %v", handler)
}
handler.Templates = append(handler.Templates, t)
}
return
}