a1d92c51cd
* plugin/forward: remove dynamic read timeout We care about an upstream being there, so we still have a dynamic dial time out (by way higher then 200ms) of 1s; this should be fairly stable for an upstream. The read timeout if more variable because of cached and non cached responses. As such remove his logic entirely. Drop to 2s read timeout. Fixes #2306 Signed-off-by: Miek Gieben <miek@miek.nl>
161 lines
3.1 KiB
Go
161 lines
3.1 KiB
Go
package forward
|
|
|
|
import (
|
|
"testing"
|
|
"time"
|
|
|
|
"github.com/coredns/coredns/plugin/pkg/dnstest"
|
|
|
|
"github.com/miekg/dns"
|
|
)
|
|
|
|
func TestCached(t *testing.T) {
|
|
s := dnstest.NewServer(func(w dns.ResponseWriter, r *dns.Msg) {
|
|
ret := new(dns.Msg)
|
|
ret.SetReply(r)
|
|
w.WriteMsg(ret)
|
|
})
|
|
defer s.Close()
|
|
|
|
tr := newTransport(s.Addr)
|
|
tr.Start()
|
|
defer tr.Stop()
|
|
|
|
c1, cache1, _ := tr.Dial("udp")
|
|
c2, cache2, _ := tr.Dial("udp")
|
|
|
|
if cache1 || cache2 {
|
|
t.Errorf("Expected non-cached connection")
|
|
}
|
|
|
|
tr.Yield(c1)
|
|
tr.Yield(c2)
|
|
c3, cached3, _ := tr.Dial("udp")
|
|
if !cached3 {
|
|
t.Error("Expected cached connection (c3)")
|
|
}
|
|
if c2 != c3 {
|
|
t.Error("Expected c2 == c3")
|
|
}
|
|
|
|
tr.Yield(c3)
|
|
|
|
// dial another protocol
|
|
c4, cached4, _ := tr.Dial("tcp")
|
|
if cached4 {
|
|
t.Errorf("Expected non-cached connection (c4)")
|
|
}
|
|
tr.Yield(c4)
|
|
}
|
|
|
|
func TestCleanupByTimer(t *testing.T) {
|
|
s := dnstest.NewServer(func(w dns.ResponseWriter, r *dns.Msg) {
|
|
ret := new(dns.Msg)
|
|
ret.SetReply(r)
|
|
w.WriteMsg(ret)
|
|
})
|
|
defer s.Close()
|
|
|
|
tr := newTransport(s.Addr)
|
|
tr.SetExpire(100 * time.Millisecond)
|
|
tr.Start()
|
|
defer tr.Stop()
|
|
|
|
c1, _, _ := tr.Dial("udp")
|
|
c2, _, _ := tr.Dial("udp")
|
|
tr.Yield(c1)
|
|
time.Sleep(10 * time.Millisecond)
|
|
tr.Yield(c2)
|
|
|
|
time.Sleep(120 * time.Millisecond)
|
|
c3, cached, _ := tr.Dial("udp")
|
|
if cached {
|
|
t.Error("Expected non-cached connection (c3)")
|
|
}
|
|
tr.Yield(c3)
|
|
|
|
time.Sleep(120 * time.Millisecond)
|
|
c4, cached, _ := tr.Dial("udp")
|
|
if cached {
|
|
t.Error("Expected non-cached connection (c4)")
|
|
}
|
|
tr.Yield(c4)
|
|
}
|
|
|
|
func TestPartialCleanup(t *testing.T) {
|
|
s := dnstest.NewServer(func(w dns.ResponseWriter, r *dns.Msg) {
|
|
ret := new(dns.Msg)
|
|
ret.SetReply(r)
|
|
w.WriteMsg(ret)
|
|
})
|
|
defer s.Close()
|
|
|
|
tr := newTransport(s.Addr)
|
|
tr.SetExpire(100 * time.Millisecond)
|
|
tr.Start()
|
|
defer tr.Stop()
|
|
|
|
c1, _, _ := tr.Dial("udp")
|
|
c2, _, _ := tr.Dial("udp")
|
|
c3, _, _ := tr.Dial("udp")
|
|
c4, _, _ := tr.Dial("udp")
|
|
c5, _, _ := tr.Dial("udp")
|
|
|
|
tr.Yield(c1)
|
|
time.Sleep(10 * time.Millisecond)
|
|
tr.Yield(c2)
|
|
time.Sleep(10 * time.Millisecond)
|
|
tr.Yield(c3)
|
|
time.Sleep(50 * time.Millisecond)
|
|
tr.Yield(c4)
|
|
time.Sleep(10 * time.Millisecond)
|
|
tr.Yield(c5)
|
|
time.Sleep(40 * time.Millisecond)
|
|
|
|
c6, _, _ := tr.Dial("udp")
|
|
if c6 != c5 {
|
|
t.Errorf("Expected c6 == c5")
|
|
}
|
|
c7, _, _ := tr.Dial("udp")
|
|
if c7 != c4 {
|
|
t.Errorf("Expected c7 == c4")
|
|
}
|
|
c8, cached, _ := tr.Dial("udp")
|
|
if cached {
|
|
t.Error("Expected non-cached connection (c8)")
|
|
}
|
|
|
|
tr.Yield(c6)
|
|
tr.Yield(c7)
|
|
tr.Yield(c8)
|
|
}
|
|
|
|
func TestCleanupAll(t *testing.T) {
|
|
s := dnstest.NewServer(func(w dns.ResponseWriter, r *dns.Msg) {
|
|
ret := new(dns.Msg)
|
|
ret.SetReply(r)
|
|
w.WriteMsg(ret)
|
|
})
|
|
defer s.Close()
|
|
|
|
tr := newTransport(s.Addr)
|
|
|
|
c1, _ := dns.DialTimeout("udp", tr.addr, maxDialTimeout)
|
|
c2, _ := dns.DialTimeout("udp", tr.addr, maxDialTimeout)
|
|
c3, _ := dns.DialTimeout("udp", tr.addr, maxDialTimeout)
|
|
|
|
tr.conns["udp"] = []*persistConn{
|
|
{c1, time.Now()},
|
|
{c2, time.Now()},
|
|
{c3, time.Now()},
|
|
}
|
|
|
|
if tr.len() != 3 {
|
|
t.Error("Expected 3 connections")
|
|
}
|
|
tr.cleanup(true)
|
|
|
|
if tr.len() > 0 {
|
|
t.Error("Expected no cached connections")
|
|
}
|
|
}
|