a536833546
* plugin/forward: add HealthChecker interface Make the HealthChecker interface and morph the current DNS health checker into that interface. Remove all whole bunch of method on Forward that didn't make sense. This is done in preparation of adding a DoH client to forward - which requires a completely different healthcheck implementation (and more, but lets start here) Signed-off-by: Miek Gieben <miek@miek.nl> * Use protocol Signed-off-by: Miek Gieben <miek@miek.nl> * Dial doesnt need to be method an Forward either Signed-off-by: Miek Gieben <miek@miek.nl> * Address comments Address various comments on the PR. Signed-off-by: Miek Gieben <miek@miek.nl>
120 lines
2.7 KiB
Go
120 lines
2.7 KiB
Go
package forward
|
|
|
|
import (
|
|
"sync/atomic"
|
|
"testing"
|
|
|
|
"github.com/coredns/coredns/plugin/pkg/dnstest"
|
|
"github.com/coredns/coredns/plugin/test"
|
|
"github.com/coredns/coredns/request"
|
|
|
|
"github.com/miekg/dns"
|
|
)
|
|
|
|
func TestLookupTruncated(t *testing.T) {
|
|
i := int32(0)
|
|
s := dnstest.NewServer(func(w dns.ResponseWriter, r *dns.Msg) {
|
|
j := atomic.LoadInt32(&i)
|
|
atomic.AddInt32(&i, 1)
|
|
|
|
if j == 0 {
|
|
ret := new(dns.Msg)
|
|
ret.SetReply(r)
|
|
ret.Truncated = true
|
|
ret.Answer = append(ret.Answer, test.A("example.org. IN A 127.0.0.1"))
|
|
w.WriteMsg(ret)
|
|
return
|
|
|
|
}
|
|
|
|
ret := new(dns.Msg)
|
|
ret.SetReply(r)
|
|
ret.Answer = append(ret.Answer, test.A("example.org. IN A 127.0.0.1"))
|
|
w.WriteMsg(ret)
|
|
})
|
|
defer s.Close()
|
|
|
|
p := NewProxy(s.Addr, DNS)
|
|
f := New()
|
|
f.SetProxy(p)
|
|
defer f.Close()
|
|
|
|
state := request.Request{W: &test.ResponseWriter{}, Req: new(dns.Msg)}
|
|
|
|
resp, err := f.Lookup(state, "example.org.", dns.TypeA)
|
|
if err != nil {
|
|
t.Fatal("Expected to receive reply, but didn't")
|
|
}
|
|
// expect answer with TC
|
|
if !resp.Truncated {
|
|
t.Error("Expected to receive reply with TC bit set, but didn't")
|
|
}
|
|
if len(resp.Answer) != 1 {
|
|
t.Error("Expected to receive original reply, but answer is missing")
|
|
}
|
|
|
|
resp, err = f.Lookup(state, "example.org.", dns.TypeA)
|
|
if err != nil {
|
|
t.Fatal("Expected to receive reply, but didn't")
|
|
}
|
|
// expect answer without TC
|
|
if resp.Truncated {
|
|
t.Error("Expected to receive reply without TC bit set, but didn't")
|
|
}
|
|
}
|
|
|
|
func TestForwardTruncated(t *testing.T) {
|
|
i := int32(0)
|
|
s := dnstest.NewServer(func(w dns.ResponseWriter, r *dns.Msg) {
|
|
j := atomic.LoadInt32(&i)
|
|
atomic.AddInt32(&i, 1)
|
|
|
|
if j == 0 {
|
|
ret := new(dns.Msg)
|
|
ret.SetReply(r)
|
|
ret.Truncated = true
|
|
ret.Answer = append(ret.Answer, test.A("example.org. IN A 127.0.0.1"))
|
|
w.WriteMsg(ret)
|
|
return
|
|
|
|
}
|
|
|
|
ret := new(dns.Msg)
|
|
ret.SetReply(r)
|
|
ret.Answer = append(ret.Answer, test.A("example.org. IN A 127.0.0.1"))
|
|
w.WriteMsg(ret)
|
|
})
|
|
defer s.Close()
|
|
|
|
f := New()
|
|
|
|
p1 := NewProxy(s.Addr, DNS)
|
|
f.SetProxy(p1)
|
|
p2 := NewProxy(s.Addr, DNS)
|
|
f.SetProxy(p2)
|
|
defer f.Close()
|
|
|
|
state := request.Request{W: &test.ResponseWriter{}, Req: new(dns.Msg)}
|
|
state.Req.SetQuestion("example.org.", dns.TypeA)
|
|
resp, err := f.Forward(state)
|
|
if err != nil {
|
|
t.Fatal("Expected to receive reply, but didn't")
|
|
}
|
|
|
|
// expect answer with TC
|
|
if !resp.Truncated {
|
|
t.Error("Expected to receive reply with TC bit set, but didn't")
|
|
}
|
|
if len(resp.Answer) != 1 {
|
|
t.Error("Expected to receive original reply, but answer is missing")
|
|
}
|
|
|
|
resp, err = f.Forward(state)
|
|
if err != nil {
|
|
t.Fatal("Expected to receive reply, but didn't")
|
|
}
|
|
// expect answer without TC
|
|
if resp.Truncated {
|
|
t.Error("Expected to receive reply without TC bit set, but didn't")
|
|
}
|
|
}
|