bfaf9e0aec
* core: add listening for other protocols
Allow CoreDNS to listen for TLS request coming over port 853. This can
be enabled with `tls://` in the config file.
Implement listening for grps:// as well.
a Corefile like:
~~~
. tls://.:1853 {
whoami
tls
}
~~~
Means we listen on 1853 for tls requests, the `tls` config item allows
configuration for TLS parameters. We *might* be tempted to use Caddy's
Let's Encrypt implementation here.
* Refactor coredns/grpc into CoreDNS
This makes gRPC a first class citizen in CoreDNS. Add defines as being
just another server.
* some cleanups
* unexport the servers
* Move protobuf dir
* Hook up TLS properly
* Fix test
* listen for TLS as well. README updates
* disable test, fix package
* fix test
* Fix tests
* Fix remaining test
* Some tests
* Make the test work
* Add grpc test from #580
* fix crash
* Fix tests
* Close conn
* README cleanups
* README
* link RFC
107 lines
2.8 KiB
Go
107 lines
2.8 KiB
Go
package root
|
|
|
|
import (
|
|
"fmt"
|
|
"io/ioutil"
|
|
"log"
|
|
"os"
|
|
"path/filepath"
|
|
"strings"
|
|
"testing"
|
|
|
|
"github.com/coredns/coredns/core/dnsserver"
|
|
|
|
"github.com/mholt/caddy"
|
|
)
|
|
|
|
func TestRoot(t *testing.T) {
|
|
log.SetOutput(ioutil.Discard)
|
|
|
|
// Predefined error substrings
|
|
parseErrContent := "Parse error:"
|
|
unableToAccessErrContent := "unable to access root path"
|
|
|
|
existingDirPath, err := getTempDirPath()
|
|
if err != nil {
|
|
t.Fatalf("BeforeTest: Failed to find an existing directory for testing! Error was: %v", err)
|
|
}
|
|
|
|
nonExistingDir := filepath.Join(existingDirPath, "highly_unlikely_to_exist_dir")
|
|
|
|
existingFile, err := ioutil.TempFile("", "root_test")
|
|
if err != nil {
|
|
t.Fatalf("BeforeTest: Failed to create temp file for testing! Error was: %v", err)
|
|
}
|
|
defer func() {
|
|
existingFile.Close()
|
|
os.Remove(existingFile.Name())
|
|
}()
|
|
|
|
inaccessiblePath := getInaccessiblePath(existingFile.Name())
|
|
|
|
tests := []struct {
|
|
input string
|
|
shouldErr bool
|
|
expectedRoot string // expected root, set to the controller. Empty for negative cases.
|
|
expectedErrContent string // substring from the expected error. Empty for positive cases.
|
|
}{
|
|
// positive
|
|
{
|
|
fmt.Sprintf(`root %s`, nonExistingDir), false, nonExistingDir, "",
|
|
},
|
|
{
|
|
fmt.Sprintf(`root %s`, existingDirPath), false, existingDirPath, "",
|
|
},
|
|
// negative
|
|
{
|
|
`root `, true, "", parseErrContent,
|
|
},
|
|
{
|
|
fmt.Sprintf(`root %s`, inaccessiblePath), true, "", unableToAccessErrContent,
|
|
},
|
|
{
|
|
fmt.Sprintf(`root {
|
|
%s
|
|
}`, existingDirPath), true, "", parseErrContent,
|
|
},
|
|
}
|
|
|
|
for i, test := range tests {
|
|
c := caddy.NewTestController("dns", test.input)
|
|
err := setup(c)
|
|
cfg := dnsserver.GetConfig(c)
|
|
|
|
if test.shouldErr && err == nil {
|
|
t.Errorf("Test %d: Expected error but found %s for input %s", i, err, test.input)
|
|
}
|
|
|
|
if err != nil {
|
|
if !test.shouldErr {
|
|
t.Errorf("Test %d: Expected no error but found one for input %s. Error was: %v", i, test.input, err)
|
|
}
|
|
|
|
if !strings.Contains(err.Error(), test.expectedErrContent) {
|
|
t.Errorf("Test %d: Expected error to contain: %v, found error: %v, input: %s", i, test.expectedErrContent, err, test.input)
|
|
}
|
|
}
|
|
|
|
// check root only if we are in a positive test.
|
|
if !test.shouldErr && test.expectedRoot != cfg.Root {
|
|
t.Errorf("Root not correctly set for input %s. Expected: %s, actual: %s", test.input, test.expectedRoot, cfg.Root)
|
|
}
|
|
}
|
|
}
|
|
|
|
// getTempDirPath returnes the path to the system temp directory. If it does not exists - an error is returned.
|
|
func getTempDirPath() (string, error) {
|
|
tempDir := os.TempDir()
|
|
_, err := os.Stat(tempDir)
|
|
if err != nil {
|
|
return "", err
|
|
}
|
|
return tempDir, nil
|
|
}
|
|
|
|
func getInaccessiblePath(file string) string {
|
|
return filepath.Join("C:", "file\x00name") // null byte in filename is not allowed on Windows AND unix
|
|
}
|