d8d2c16905
Traces are currently working properly with datadog with the exception of having the ability to facet the tags  In order to get valuable graph in dashboard the tag on the metrics need to be faceted by datadog. This PR update the tags with facetable path. While keeping backward compatibility with existing path for zipkin. Graph like:      Signed-off-by: bob <bob.bouteillier@datadoghq.com>
109 lines
3.3 KiB
Go
109 lines
3.3 KiB
Go
package trace
|
|
|
|
import (
|
|
"context"
|
|
"testing"
|
|
|
|
"github.com/coredns/caddy"
|
|
"github.com/coredns/coredns/plugin/pkg/dnstest"
|
|
"github.com/coredns/coredns/plugin/pkg/rcode"
|
|
"github.com/coredns/coredns/plugin/test"
|
|
"github.com/coredns/coredns/request"
|
|
|
|
"github.com/miekg/dns"
|
|
"github.com/opentracing/opentracing-go/mocktracer"
|
|
)
|
|
|
|
func TestStartup(t *testing.T) {
|
|
m, err := traceParse(caddy.NewTestController("dns", `trace`))
|
|
if err != nil {
|
|
t.Errorf("Error parsing test input: %s", err)
|
|
return
|
|
}
|
|
if m.Name() != "trace" {
|
|
t.Errorf("Wrong name from GetName: %s", m.Name())
|
|
}
|
|
err = m.OnStartup()
|
|
if err != nil {
|
|
t.Errorf("Error starting tracing plugin: %s", err)
|
|
return
|
|
}
|
|
|
|
if m.tagSet != tagByProvider["default"] {
|
|
t.Errorf("TagSet by proviser hasn't been corectly initialized")
|
|
}
|
|
|
|
if m.Tracer() == nil {
|
|
t.Errorf("Error, no tracer created")
|
|
}
|
|
}
|
|
|
|
func TestTrace(t *testing.T) {
|
|
cases := []struct {
|
|
name string
|
|
rcode int
|
|
question *dns.Msg
|
|
server string
|
|
}{
|
|
{
|
|
name: "NXDOMAIN",
|
|
rcode: dns.RcodeNameError,
|
|
question: new(dns.Msg).SetQuestion("example.org.", dns.TypeA),
|
|
},
|
|
{
|
|
name: "NOERROR",
|
|
rcode: dns.RcodeSuccess,
|
|
question: new(dns.Msg).SetQuestion("example.net.", dns.TypeCNAME),
|
|
},
|
|
}
|
|
defaultTagSet := tagByProvider["default"]
|
|
for _, tc := range cases {
|
|
t.Run(tc.name, func(t *testing.T) {
|
|
w := dnstest.NewRecorder(&test.ResponseWriter{})
|
|
m := mocktracer.New()
|
|
tr := &trace{
|
|
Next: test.HandlerFunc(func(_ context.Context, w dns.ResponseWriter, r *dns.Msg) (int, error) {
|
|
m := new(dns.Msg)
|
|
m.SetRcode(r, tc.rcode)
|
|
w.WriteMsg(m)
|
|
return tc.rcode, nil
|
|
}),
|
|
every: 1,
|
|
tracer: m,
|
|
tagSet: defaultTagSet,
|
|
}
|
|
ctx := context.TODO()
|
|
if _, err := tr.ServeDNS(ctx, w, tc.question); err != nil {
|
|
t.Fatalf("Error during tr.ServeDNS(ctx, w, %v): %v", tc.question, err)
|
|
}
|
|
|
|
fs := m.FinishedSpans()
|
|
// Each trace consists of two spans; the root and the Next function.
|
|
if len(fs) != 2 {
|
|
t.Fatalf("Unexpected span count: len(fs): want 2, got %v", len(fs))
|
|
}
|
|
|
|
rootSpan := fs[1]
|
|
req := request.Request{W: w, Req: tc.question}
|
|
if rootSpan.OperationName != defaultTopLevelSpanName {
|
|
t.Errorf("Unexpected span name: rootSpan.Name: want %v, got %v", defaultTopLevelSpanName, rootSpan.OperationName)
|
|
}
|
|
|
|
if rootSpan.Tag(defaultTagSet.Name) != req.Name() {
|
|
t.Errorf("Unexpected span tag: rootSpan.Tag(%v): want %v, got %v", defaultTagSet.Name, req.Name(), rootSpan.Tag(defaultTagSet.Name))
|
|
}
|
|
if rootSpan.Tag(defaultTagSet.Type) != req.Type() {
|
|
t.Errorf("Unexpected span tag: rootSpan.Tag(%v): want %v, got %v", defaultTagSet.Type, req.Type(), rootSpan.Tag(defaultTagSet.Type))
|
|
}
|
|
if rootSpan.Tag(defaultTagSet.Proto) != req.Proto() {
|
|
t.Errorf("Unexpected span tag: rootSpan.Tag(%v): want %v, got %v", defaultTagSet.Proto, req.Proto(), rootSpan.Tag(defaultTagSet.Proto))
|
|
}
|
|
if rootSpan.Tag(defaultTagSet.Remote) != req.IP() {
|
|
t.Errorf("Unexpected span tag: rootSpan.Tag(%v): want %v, got %v", defaultTagSet.Remote, req.IP(), rootSpan.Tag(defaultTagSet.Remote))
|
|
}
|
|
if rootSpan.Tag(defaultTagSet.Rcode) != rcode.ToString(tc.rcode) {
|
|
t.Errorf("Unexpected span tag: rootSpan.Tag(%v): want %v, got %v", defaultTagSet.Rcode, rcode.ToString(tc.rcode), rootSpan.Tag(defaultTagSet.Rcode))
|
|
}
|
|
})
|
|
}
|
|
}
|