db6c9a3f01
Make the methods that handle Metrics all use pointer receivers to fix sync.Once not being initialized. Finish the setup_test to test for failures. And make the check for the address more strict and return an error when it does not have a port number. Add a toplevel test that starts a CoreDNS server with metrics enabled so we catch these errors in the future.
96 lines
2.4 KiB
Go
96 lines
2.4 KiB
Go
package metrics
|
|
|
|
import (
|
|
"time"
|
|
|
|
"github.com/miekg/coredns/middleware"
|
|
"github.com/miekg/coredns/middleware/pkg/dnsrecorder"
|
|
"github.com/miekg/coredns/middleware/pkg/rcode"
|
|
"github.com/miekg/coredns/request"
|
|
|
|
"github.com/miekg/dns"
|
|
"golang.org/x/net/context"
|
|
)
|
|
|
|
// ServeDNS implements the Handler interface.
|
|
func (m *Metrics) ServeDNS(ctx context.Context, w dns.ResponseWriter, r *dns.Msg) (int, error) {
|
|
state := request.Request{W: w, Req: r}
|
|
|
|
qname := state.QName()
|
|
zone := middleware.Zones(m.ZoneNames).Matches(qname)
|
|
if zone == "" {
|
|
zone = "."
|
|
}
|
|
|
|
// Record response to get status code and size of the reply.
|
|
rw := dnsrecorder.New(w)
|
|
status, err := m.Next.ServeDNS(ctx, rw, r)
|
|
|
|
Report(state, zone, rcode.ToString(rw.Rcode), rw.Size, rw.Start)
|
|
|
|
return status, err
|
|
}
|
|
|
|
// Report is a plain reporting function that the server can use for REFUSED and other
|
|
// queries that are turned down because they don't match any middleware.
|
|
func Report(req request.Request, zone, rcode string, size int, start time.Time) {
|
|
if requestCount == nil {
|
|
// no metrics are enabled
|
|
return
|
|
}
|
|
|
|
// Proto and Family
|
|
net := req.Proto()
|
|
fam := "1"
|
|
if req.Family() == 2 {
|
|
fam = "2"
|
|
}
|
|
|
|
typ := req.QType()
|
|
|
|
requestCount.WithLabelValues(zone, net, fam).Inc()
|
|
requestDuration.WithLabelValues(zone).Observe(float64(time.Since(start) / time.Millisecond))
|
|
|
|
if req.Do() {
|
|
requestDo.WithLabelValues(zone).Inc()
|
|
}
|
|
|
|
if _, known := monitorType[typ]; known {
|
|
requestType.WithLabelValues(zone, dns.Type(typ).String()).Inc()
|
|
} else {
|
|
requestType.WithLabelValues(zone, other).Inc()
|
|
}
|
|
|
|
if typ == dns.TypeIXFR || typ == dns.TypeAXFR {
|
|
responseTransferSize.WithLabelValues(zone, net).Observe(float64(size))
|
|
requestTransferSize.WithLabelValues(zone, net).Observe(float64(req.Size()))
|
|
} else {
|
|
responseSize.WithLabelValues(zone, net).Observe(float64(size))
|
|
requestSize.WithLabelValues(zone, net).Observe(float64(req.Size()))
|
|
}
|
|
|
|
responseRcode.WithLabelValues(zone, rcode).Inc()
|
|
}
|
|
|
|
var monitorType = map[uint16]bool{
|
|
dns.TypeAAAA: true,
|
|
dns.TypeA: true,
|
|
dns.TypeCNAME: true,
|
|
dns.TypeDNSKEY: true,
|
|
dns.TypeDS: true,
|
|
dns.TypeMX: true,
|
|
dns.TypeNSEC3: true,
|
|
dns.TypeNSEC: true,
|
|
dns.TypeNS: true,
|
|
dns.TypePTR: true,
|
|
dns.TypeRRSIG: true,
|
|
dns.TypeSOA: true,
|
|
dns.TypeSRV: true,
|
|
dns.TypeTXT: true,
|
|
// Meta Qtypes
|
|
dns.TypeIXFR: true,
|
|
dns.TypeAXFR: true,
|
|
dns.TypeANY: true,
|
|
}
|
|
|
|
const other = "other"
|