Make the methods that handle Metrics all use pointer receivers to fix sync.Once not being initialized. Finish the setup_test to test for failures. And make the check for the address more strict and return an error when it does not have a port number. Add a toplevel test that starts a CoreDNS server with metrics enabled so we catch these errors in the future.
157 lines
4.8 KiB
Go
157 lines
4.8 KiB
Go
// Package metrics implement a handler and middleware that provides Prometheus
|
|
// metrics.
|
|
package metrics
|
|
|
|
import (
|
|
"log"
|
|
"net"
|
|
"net/http"
|
|
"sync"
|
|
|
|
"github.com/miekg/coredns/middleware"
|
|
|
|
"github.com/prometheus/client_golang/prometheus"
|
|
)
|
|
|
|
var (
|
|
requestCount *prometheus.CounterVec
|
|
requestDuration *prometheus.HistogramVec
|
|
requestSize *prometheus.HistogramVec
|
|
requestTransferSize *prometheus.HistogramVec
|
|
requestDo *prometheus.CounterVec
|
|
requestType *prometheus.CounterVec
|
|
|
|
responseSize *prometheus.HistogramVec
|
|
responseTransferSize *prometheus.HistogramVec
|
|
responseRcode *prometheus.CounterVec
|
|
)
|
|
|
|
// Metrics holds the prometheus configuration. The metrics' path is fixed to be /metrics
|
|
type Metrics struct {
|
|
Next middleware.Handler
|
|
Addr string
|
|
ln net.Listener
|
|
mux *http.ServeMux
|
|
Once sync.Once
|
|
ZoneNames []string
|
|
}
|
|
|
|
// OnStartup sets up the metrics on startup.
|
|
func (m *Metrics) OnStartup() error {
|
|
m.Once.Do(func() {
|
|
define()
|
|
|
|
ln, err := net.Listen("tcp", m.Addr)
|
|
if err != nil {
|
|
log.Printf("[ERROR] Failed to start metrics handler: %s", err)
|
|
return
|
|
}
|
|
|
|
m.ln = ln
|
|
|
|
m.mux = http.NewServeMux()
|
|
|
|
prometheus.MustRegister(requestCount)
|
|
prometheus.MustRegister(requestDuration)
|
|
prometheus.MustRegister(requestSize)
|
|
prometheus.MustRegister(requestTransferSize)
|
|
prometheus.MustRegister(requestDo)
|
|
prometheus.MustRegister(requestType)
|
|
|
|
prometheus.MustRegister(responseSize)
|
|
prometheus.MustRegister(responseTransferSize)
|
|
prometheus.MustRegister(responseRcode)
|
|
|
|
m.mux.Handle(path, prometheus.Handler())
|
|
|
|
go func() {
|
|
http.Serve(m.ln, m.mux)
|
|
}()
|
|
})
|
|
return nil
|
|
}
|
|
|
|
// OnShutdown tears down the metrics on shutdown.
|
|
func (m *Metrics) OnShutdown() error {
|
|
if m.ln != nil {
|
|
return m.ln.Close()
|
|
}
|
|
return nil
|
|
}
|
|
|
|
func define() {
|
|
requestCount = prometheus.NewCounterVec(prometheus.CounterOpts{
|
|
Namespace: middleware.Namespace,
|
|
Subsystem: subsystem,
|
|
Name: "request_count_total",
|
|
Help: "Counter of DNS requests made per zone, protocol and family.",
|
|
}, []string{"zone", "proto", "family"})
|
|
|
|
requestDuration = prometheus.NewHistogramVec(prometheus.HistogramOpts{
|
|
Namespace: middleware.Namespace,
|
|
Subsystem: subsystem,
|
|
Name: "request_duration_milliseconds",
|
|
Buckets: append(prometheus.DefBuckets, []float64{50, 100, 200, 500, 1000, 2000, 3000, 4000, 5000}...),
|
|
Help: "Histogram of the time (in milliseconds) each request took.",
|
|
}, []string{"zone"})
|
|
|
|
requestSize = prometheus.NewHistogramVec(prometheus.HistogramOpts{
|
|
Namespace: middleware.Namespace,
|
|
Subsystem: subsystem,
|
|
Name: "request_size_bytes",
|
|
Help: "Size of the EDNS0 UDP buffer in bytes (64K for TCP).",
|
|
Buckets: []float64{0, 100, 200, 300, 400, 511, 1023, 2047, 4095, 8291, 16e3, 32e3, 48e3, 64e3},
|
|
}, []string{"zone", "proto"})
|
|
|
|
requestTransferSize = prometheus.NewHistogramVec(prometheus.HistogramOpts{
|
|
Namespace: middleware.Namespace,
|
|
Subsystem: subsystem,
|
|
Name: "request_transfer_size_bytes",
|
|
Help: "Size of the incoming zone transfer in bytes.",
|
|
Buckets: []float64{0, 100, 200, 300, 400, 511, 1023, 2047, 4095, 8291, 16e3, 32e3, 48e3, 64e3},
|
|
}, []string{"zone", "proto"})
|
|
|
|
requestDo = prometheus.NewCounterVec(prometheus.CounterOpts{
|
|
Namespace: middleware.Namespace,
|
|
Subsystem: subsystem,
|
|
Name: "request_do_count_total",
|
|
Help: "Counter of DNS requests with DO bit set per zone.",
|
|
}, []string{"zone"})
|
|
|
|
requestType = prometheus.NewCounterVec(prometheus.CounterOpts{
|
|
Namespace: middleware.Namespace,
|
|
Subsystem: subsystem,
|
|
Name: "request_type_count_total",
|
|
Help: "Counter of DNS requests per type, per zone.",
|
|
}, []string{"zone", "type"})
|
|
|
|
responseSize = prometheus.NewHistogramVec(prometheus.HistogramOpts{
|
|
Namespace: middleware.Namespace,
|
|
Subsystem: subsystem,
|
|
Name: "response_size_bytes",
|
|
Help: "Size of the returned response in bytes.",
|
|
Buckets: []float64{0, 100, 200, 300, 400, 511, 1023, 2047, 4095, 8291, 16e3, 32e3, 48e3, 64e3},
|
|
}, []string{"zone", "proto"})
|
|
|
|
responseTransferSize = prometheus.NewHistogramVec(prometheus.HistogramOpts{
|
|
Namespace: middleware.Namespace,
|
|
Subsystem: subsystem,
|
|
Name: "response_transfer_size_bytes",
|
|
Help: "Size of the returned zone transfer in bytes.",
|
|
Buckets: []float64{0, 100, 200, 300, 400, 511, 1023, 2047, 4095, 8291, 16e3, 32e3, 48e3, 64e3},
|
|
}, []string{"zone", "proto"})
|
|
|
|
responseRcode = prometheus.NewCounterVec(prometheus.CounterOpts{
|
|
Namespace: middleware.Namespace,
|
|
Subsystem: subsystem,
|
|
Name: "response_rcode_count_total",
|
|
Help: "Counter of response status codes.",
|
|
}, []string{"zone", "rcode"})
|
|
}
|
|
|
|
const (
|
|
// Dropped indicates we dropped the query before any handling. It has no closing dot, so it can not be a valid zone.
|
|
Dropped = "dropped"
|
|
subsystem = "dns"
|
|
path = "/metrics"
|
|
)
|