f96cf27193
* mw/federaration This PR add the federation back as a middleware to keep it more contained from the main kubernetes code. It also makes parseRequest less import and pushes this functionlity down in the k.Entries. This minimizes (or tries to) the importance for the qtype in the query. In the end the qtype checking should only happen in ServeDNS - but for k8s this might proof difficult. Numerous other cleanup in code and kubernetes tests. * up test coverage
73 lines
1.9 KiB
Go
73 lines
1.9 KiB
Go
package kubernetes
|
|
|
|
import (
|
|
"testing"
|
|
|
|
"github.com/coredns/coredns/request"
|
|
|
|
"github.com/miekg/dns"
|
|
)
|
|
|
|
func TestParseRequest(t *testing.T) {
|
|
k := New([]string{zone})
|
|
|
|
tests := []struct {
|
|
query string
|
|
qtype uint16
|
|
expected string // output from r.String()
|
|
}{
|
|
{
|
|
// valid SRV request
|
|
"_http._tcp.webs.mynamespace.svc.inter.webs.test.", dns.TypeSRV,
|
|
"http.tcp..webs.mynamespace.svc.intern.webs.tests.",
|
|
},
|
|
{
|
|
// wildcard acceptance
|
|
"*.any.*.any.svc.inter.webs.test.", dns.TypeSRV,
|
|
"*.any..*.any.svc.intern.webs.tests.",
|
|
},
|
|
{
|
|
// A request of endpoint
|
|
"1-2-3-4.webs.mynamespace.svc.inter.webs.test.", dns.TypeA,
|
|
"..1-2-3-4.webs.mynamespace.svc.intern.webs.tests.",
|
|
},
|
|
}
|
|
for i, tc := range tests {
|
|
m := new(dns.Msg)
|
|
m.SetQuestion(tc.query, tc.qtype)
|
|
state := request.Request{Zone: zone, Req: m}
|
|
|
|
r, e := k.parseRequest(state)
|
|
if e != nil {
|
|
t.Errorf("Test %d, expected no error, got '%v'.", i, e)
|
|
}
|
|
rs := r.String()
|
|
if rs != tc.expected {
|
|
t.Errorf("Test %d, expected (stringyfied) recordRequest: %s, got %s", i, tc.expected, rs)
|
|
}
|
|
}
|
|
}
|
|
|
|
func TestParseInvalidRequest(t *testing.T) {
|
|
k := New([]string{zone})
|
|
|
|
invalid := map[string]uint16{
|
|
"_http._tcp.webs.mynamespace.svc.inter.webs.test.": dns.TypeA, // A requests cannot have port or protocol
|
|
"_http._pcp.webs.mynamespace.svc.inter.webs.test.": dns.TypeSRV, // SRV protocol must be tcp or udp
|
|
"_http._tcp.ep.webs.ns.svc.inter.webs.test.": dns.TypeSRV, // SRV requests cannot have an endpoint
|
|
"_*._*.webs.mynamespace.svc.inter.webs.test.": dns.TypeSRV, // SRV request with invalid wildcards
|
|
|
|
}
|
|
|
|
for query, qtype := range invalid {
|
|
m := new(dns.Msg)
|
|
m.SetQuestion(query, qtype)
|
|
state := request.Request{Zone: zone, Req: m}
|
|
|
|
if _, e := k.parseRequest(state); e == nil {
|
|
t.Errorf("Expected error from %s:%d, got none", query, qtype)
|
|
}
|
|
}
|
|
}
|
|
|
|
const zone = "intern.webs.tests."
|