fb7fcff982
Be more explicit in the logs when a notify fails. New notify error message looks like: 2016/11/07 18:21:42 [ERROR] Notify for zone "example.org." was not accepted by "8.8.8.8:53": rcode was "SERVFAIL" Correctly pick up secondaries When multiple secondary are specified make sure they are picked up. Fixes #393 #398
72 lines
1.8 KiB
Go
72 lines
1.8 KiB
Go
package file
|
|
|
|
import (
|
|
"fmt"
|
|
"log"
|
|
|
|
"github.com/miekg/coredns/middleware"
|
|
"github.com/miekg/coredns/middleware/pkg/rcode"
|
|
"github.com/miekg/coredns/request"
|
|
|
|
"github.com/miekg/dns"
|
|
)
|
|
|
|
// isNotify checks if state is a notify message and if so, will *also* check if it
|
|
// is from one of the configured masters. If not it will not be a valid notify
|
|
// message. If the zone z is not a secondary zone the message will also be ignored.
|
|
func (z *Zone) isNotify(state request.Request) bool {
|
|
if state.Req.Opcode != dns.OpcodeNotify {
|
|
return false
|
|
}
|
|
if len(z.TransferFrom) == 0 {
|
|
return false
|
|
}
|
|
remote := middleware.Addr(state.IP()).Normalize()
|
|
for _, from := range z.TransferFrom {
|
|
if from == remote {
|
|
return true
|
|
}
|
|
}
|
|
return false
|
|
}
|
|
|
|
// Notify will send notifies to all configured TransferTo IP addresses.
|
|
func (z *Zone) Notify() {
|
|
go notify(z.origin, z.TransferTo)
|
|
}
|
|
|
|
// notify sends notifies to the configured remote servers. It will try up to three times
|
|
// before giving up on a specific remote. We will sequentially loop through "to"
|
|
// until they all have replied (or have 3 failed attempts).
|
|
func notify(zone string, to []string) error {
|
|
m := new(dns.Msg)
|
|
m.SetNotify(zone)
|
|
c := new(dns.Client)
|
|
|
|
for _, t := range to {
|
|
if t == "*" {
|
|
continue
|
|
}
|
|
if err := notifyAddr(c, m, t); err != nil {
|
|
log.Printf("[ERROR] " + err.Error())
|
|
} else {
|
|
log.Printf("[INFO] Sent notify for zone %q to %q", zone, t)
|
|
}
|
|
}
|
|
return nil
|
|
}
|
|
|
|
func notifyAddr(c *dns.Client, m *dns.Msg, s string) error {
|
|
code := dns.RcodeSuccess
|
|
for i := 0; i < 3; i++ {
|
|
ret, _, err := c.Exchange(m, s)
|
|
if err != nil {
|
|
continue
|
|
}
|
|
code = ret.Rcode
|
|
if code == dns.RcodeSuccess {
|
|
return nil
|
|
}
|
|
}
|
|
return fmt.Errorf("Notify for zone %q was not accepted by %q: rcode was %q", m.Question[0].Name, s, rcode.ToString(code))
|
|
}
|