TrueCloudLab/distribution
12
0
Fork 3
Code Issues 2 Pull requests Projects Releases 2 Packages Wiki Activity Actions

Merge pull request #474 from stevvooe/goroutine-leak-notifications

Browse source 
Address possible goroutine leak in notification library
This commit is contained in:
Stephen Day 2015-04-29 18:48:15 -07:00
commit 3283ef1949
1 changed files with 2 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
notifications/http.go
View file

@ -53,6 +53,7 @@ type httpStatusListener interface {
func (hs *httpSink) Write(events ...Event) error { func (hs *httpSink) Write(events ...Event) error {
hs.mu.Lock() hs.mu.Lock()
defer hs.mu.Unlock() defer hs.mu.Unlock()
defer hs.client.Transport.(*headerRoundTripper).CloseIdleConnections()
if hs.closed { if hs.closed {
return ErrSinkClosed return ErrSinkClosed
@ -83,6 +84,7 @@ func (hs *httpSink) Write(events ...Event) error {
return fmt.Errorf("%v: error posting: %v", hs, err) return fmt.Errorf("%v: error posting: %v", hs, err)
} }
defer resp.Body.Close()
// The notifier will treat any 2xx or 3xx response as accepted by the // The notifier will treat any 2xx or 3xx response as accepted by the
// endpoint. // endpoint.