From 41c87559c60b3781ac2ee4d97931ea9882537558 Mon Sep 17 00:00:00 2001 From: Adam Duke Date: Thu, 21 Jul 2016 19:14:32 -0400 Subject: [PATCH] reorder Dockerfile steps for better layer caching Running `apk add` before copying source into the image takes better adavantage of layer caching when developing and regularly building the image. This avoids source code changes invalidating the `apk add` layer and causing that step to run on every image build. Signed-off-by: Adam Duke --- Dockerfile | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/Dockerfile b/Dockerfile index fa9cd4627..bc3c78577 100644 --- a/Dockerfile +++ b/Dockerfile @@ -3,13 +3,13 @@ FROM golang:1.6-alpine ENV DISTRIBUTION_DIR /go/src/github.com/docker/distribution ENV DOCKER_BUILDTAGS include_oss include_gcs +RUN set -ex \ + && apk add --no-cache make git + WORKDIR $DISTRIBUTION_DIR COPY . $DISTRIBUTION_DIR COPY cmd/registry/config-dev.yml /etc/docker/registry/config.yml -RUN set -ex \ - && apk add --no-cache make git - RUN make PREFIX=/go clean binaries VOLUME ["/var/lib/registry"]