TrueCloudLab/distribution
13
0
Fork 3
Code Issues 2 Pull requests Projects Releases 2 Packages Wiki Activity Actions

Merge pull request #4067 from milosgajdos/dont-close-request-body

Browse source 
Do not close HTTP request body in HTTP handler
This commit is contained in:
Milos Gajdos 2023-09-23 23:08:04 +01:00 committed by GitHub
commit 5e6af2f13f
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
2 changed files with 0 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
registry/handlers/app.go
View file

@ -584,8 +584,6 @@ func (app *App) configureSecret(configuration *configuration.Configuration) {
} }
func (app *App) ServeHTTP(w http.ResponseWriter, r *http.Request) { func (app *App) ServeHTTP(w http.ResponseWriter, r *http.Request) {
defer r.Body.Close() // ensure that request body is always closed.
// Prepare the context with our own little decorations. // Prepare the context with our own little decorations.
ctx := r.Context() ctx := r.Context()
ctx = dcontext.WithRequest(ctx, r) ctx = dcontext.WithRequest(ctx, r)

2
registry/handlers/tags.go
View file

@ -34,8 +34,6 @@ type tagsAPIResponse struct {
// GetTags returns a json list of tags for a specific image name. // GetTags returns a json list of tags for a specific image name.
func (th *tagsHandler) GetTags(w http.ResponseWriter, r *http.Request) { func (th *tagsHandler) GetTags(w http.ResponseWriter, r *http.Request) {
defer r.Body.Close()
tagService := th.Repository.Tags(th) tagService := th.Repository.Tags(th)
tags, err := tagService.All(th) tags, err := tagService.All(th)
if err != nil { if err != nil {