From 8081a13cdff97bf0029eb2e7e0d15ced9954ce5a Mon Sep 17 00:00:00 2001 From: xiekeyang Date: Wed, 4 Mar 2015 16:02:50 +0800 Subject: [PATCH] :func Validate in digest doesn't filter no-hex data --- digest/digest.go | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/digest/digest.go b/digest/digest.go index efbe49bd7..06e9fad80 100644 --- a/digest/digest.go +++ b/digest/digest.go @@ -112,6 +112,10 @@ func (d Digest) Validate() error { // Continue on for general parser + if !DigestRegexp.MatchString(s) { + return ErrDigestInvalidFormat + } + i := strings.Index(s, ":") if i < 0 { return ErrDigestInvalidFormat @@ -129,8 +133,6 @@ func (d Digest) Validate() error { return ErrDigestUnsupported } - // TODO(stevvooe): Use DigestRegexp to validate digest here. - return nil }