From 8163e20c6fcbea2d5e3d621c3bbba8a80f32cf8b Mon Sep 17 00:00:00 2001 From: Sebastiaan van Stijn Date: Fri, 11 Nov 2022 13:08:45 +0100 Subject: [PATCH] reference: splitDockerDomain: remove incorrect "TODO" My mistake; I added this TODO in 552b1526c6821a84daab48cbc7f5456ae215d6c4, but it only applies to familiarizeName. Signed-off-by: Sebastiaan van Stijn --- reference/normalize.go | 5 ----- 1 file changed, 5 deletions(-) diff --git a/reference/normalize.go b/reference/normalize.go index 47de5850a..4598bf530 100644 --- a/reference/normalize.go +++ b/reference/normalize.go @@ -96,11 +96,6 @@ func splitDockerDomain(name string) (domain, remainder string) { if domain == legacyDefaultDomain { domain = defaultDomain } - // TODO(thaJeztah): this check may be too strict, as it assumes the - // "library/" namespace does not have nested namespaces. While this - // is true (currently), technically it would be possible for Docker - // Hub to use those (e.g. "library/distros/ubuntu:latest"). - // See https://github.com/distribution/distribution/pull/3769#issuecomment-1302031785. if domain == defaultDomain && !strings.ContainsRune(remainder, '/') { remainder = officialRepoPrefix + remainder }