Remove timeout for http.Client in registry/client/repository.go.
Timeouts should not be a discrete period of time, because they end up being arbitrary and may be difficult to gauge correctly against very large Docker layers. Rather, timeouts should be set at the transport level using the SetDeadline attribute on a net.Conn object. Signed-off-by: Jon Poler <jonathan.poler@apcera.com>
This commit is contained in:
parent
dc19b5496a
commit
855ecb8440
1 changed files with 0 additions and 1 deletions
|
@ -34,7 +34,6 @@ func NewRepository(ctx context.Context, name, baseURL string, transport http.Rou
|
|||
|
||||
client := &http.Client{
|
||||
Transport: transport,
|
||||
Timeout: 1 * time.Minute,
|
||||
// TODO(dmcgowan): create cookie jar
|
||||
}
|
||||
|
||||
|
|
Loading…
Reference in a new issue