TrueCloudLab/distribution
13
0
Fork 3
Code Issues 3 Pull requests Projects Releases 2 Packages Wiki Activity Actions

fix: use http.DefaultTransport in S3 client

Browse source 
Unfortunately one of the changes we merged in broken the support for
http.ProxyFromEnvironment https://pkg.go.dev/net/http#ProxyFromEnvironment

This commit attempts to fix that by cloning the http.DefaultTransport
and updating it accordingly.

Signed-off-by: Milos Gajdos <milosthegajdos@gmail.com>
This commit is contained in:
Milos Gajdos 2023-12-15 09:34:06 +00:00
parent b8fb08e0a1
commit 8fa7a81cb2
No known key found for this signature in database
1 changed files with 2 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

5
registry/storage/driver/s3-aws/s3.go
View file

@ -560,9 +560,8 @@ func New(ctx context.Context, params DriverParameters) (*Driver, error) {
} }
if params.SkipVerify { if params.SkipVerify {
httpTransport := &http.Transport{ httpTransport := http.DefaultTransport.(*http.Transport).Clone()
TLSClientConfig: &tls.Config{InsecureSkipVerify: true}, httpTransport.TLSClientConfig = &tls.Config{InsecureSkipVerify: true}
}
awsConfig.WithHTTPClient(&http.Client{ awsConfig.WithHTTPClient(&http.Client{
Transport: httpTransport, Transport: httpTransport,
}) })